Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug in node-webkit environment #3

Open
yuguo opened this Issue Nov 22, 2013 · 1 comment

Comments

Projects
None yet
2 participants

yuguo commented Nov 22, 2013

I'm running node-bin-packing in node-webkit environment, and it crashes.

after some research, i found that in this file:

https://github.com/jsmarkus/node-bin-packing/blob/master/js/packer.growing.js

(typeof window !== 'undefined' ? window : module.exports);

is not correct. it assume if an environment don't have window variable, it's node, but node-webkit have window and module and exports variable as global variables, and i do want to assign the anonymous function to module.exports.

so i recommend changing the judge condition, thank you!

@jonathandelgado jonathandelgado referenced this issue in twolfson/layout Jan 26, 2015

Closed

Consider Removing binpacking Dep #6

It looks like https://github.com/bryanburgers/bin-pack is node only so that should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment