Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for `browser.permission.remove` #22

Open
bfred-it opened this issue Jul 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@bfred-it
Copy link

commented Jul 4, 2019

I had opened a PR for this but then I realized this file is generated

-     function remove(permissions: Permissions): Promise<void>;
+     function remove(permissions: Permissions): Promise<boolean>;

This is the required type change. The readme doesn't say how this change can be made in this repo.

Also it could mention that this API has a polyfill, like I did on MDN: https://github.com/mdn/browser-compat-data/pull/4423/files

-	 * @deprecated Unsupported on Firefox at this time.
+	 * @deprecated Unsupported on Firefox at this time. Polyfill available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.