Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs: do not run nvm if not needed #28

merged 1 commit into from Dec 28, 2021


Copy link

@jsmrcaga jsmrcaga commented Dec 27, 2021

Remove NVM execution and installation if it is not required:

  • if user did not set a specific node version
  • if repo does not possess a .nvmrc file

Linked to issue:

Copy link
Owner Author

@tpluscode could you review this PR and check if it still matches your use-cases ?

@jsmrcaga jsmrcaga linked an issue Dec 27, 2021 that may be closed by this pull request
Copy link

Yes, that works for me!

@jsmrcaga jsmrcaga merged commit fb6a5f9 into master Dec 28, 2021
@jsmrcaga jsmrcaga deleted the jo/do-not-run-nvm-if-not-needed branch December 28, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Build fails because of nvm while it's optional
3 participants