fix: use $GITHUB_OUTPUT instead set-output(deprecated) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmrcaga
requested changes
Nov 29, 2022
entrypoint.sh
Outdated
| echo "NETLIFY_OUTPUT<<EOF" >> $GITHUB_OUTPUT | ||
| echo "$NETLIFY_OUTPUT" >> $GITHUB_OUTPUT | ||
| echo "EOF" >> $GITHUB_OUTPUT | ||
|
|
||
| echo "NETLIFY_PREVIEW_URL<<EOF" >> $GITHUB_OUTPUT | ||
| echo "$NETLIFY_PREVIEW_URL" >> $GITHUB_OUTPUT | ||
| echo "EOF" >> $GITHUB_OUTPUT | ||
|
|
||
| echo "NETLIFY_LOGS_URL<<EOF" >> $GITHUB_OUTPUT | ||
| echo "$NETLIFY_LOGS_URL" >> $GITHUB_OUTPUT | ||
| echo "EOF" >> $GITHUB_OUTPUT | ||
|
|
||
| echo "NETLIFY_LIVE_URL<<EOF" >> $GITHUB_OUTPUT | ||
| echo "$NETLIFY_LIVE_URL" >> $GITHUB_OUTPUT | ||
| echo "EOF" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Since these are single line outputs I believe we could use the simpler one-line syntax
ex:
echo "action_state=yellow" >> $GITHUB_ENVThere was a problem hiding this comment.
yes @jsmrcaga, thank you for the review!
you can check again
H4K1
force-pushed
the
feature/modify-set-output
branch
from
080eaf4
to
281fd99
Compare
jsmrcaga
approved these changes
Nov 30, 2022
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the deployments I noticed that some warnings were appearing due to the
set-outputbeing deprecated, I made the necessary changes to eliminate the warning!I hope this is helpful, best regards
warning image:
links:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings