Skip to content

Add response status for POST with inexistent related resource.#1036

Merged
ethanresnick merged 3 commits into
json-api:gh-pagesfrom
beauby:404-create-missing-related
Sep 28, 2016
Merged

Add response status for POST with inexistent related resource.#1036
ethanresnick merged 3 commits into
json-api:gh-pagesfrom
beauby:404-create-missing-related

Conversation

@beauby

@beauby beauby commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

related: #1033

@dgeb

dgeb commented Aug 5, 2016

Copy link
Copy Markdown
Member

I agree that this should be spelled out under creating resources, as it is under updating resources (see http://jsonapi.org/format/#crud-updating-responses-404).

We need to decide if this should land in 1.0, 1.1, or both.

@beauby

beauby commented Sep 28, 2016

Copy link
Copy Markdown
Contributor Author

Anything more I can do to help on this one?

@dgeb

dgeb commented Sep 28, 2016

Copy link
Copy Markdown
Member

@beauby I've labeled this as needing further discussion because of the MUST.

@beauby

beauby commented Sep 28, 2016

Copy link
Copy Markdown
Contributor Author

Fair enough – my understanding was that this was highly implied by the spirit of the spec, but forgotten to be clearly spelled out.

@dgeb

dgeb commented Sep 28, 2016

Copy link
Copy Markdown
Member

I agree. I think this change is entirely consistent with the "updating resources" section, and I am not really in favor of downgrading the MUST because its omission was just an oversight.

@ethanresnick

Copy link
Copy Markdown
Member

I trust @dgeb's judgement re adding the MUST.

Re landing in 1.0, 1.1 or both...to date, we've been pretty loose about backporting things to 1.0, and I don't think that's been a problem. If we want to get stricter at some point about the published versions being immutable artifacts, we can, but I'm not sure what the value of that would be now.

Regardless, @beauby please update this pr so that it changes the normative-statements.json files as well. (See e.g. #1102.)

@beauby

beauby commented Sep 28, 2016

Copy link
Copy Markdown
Contributor Author

@ethanresnick Done.

@dgeb

dgeb commented Sep 28, 2016

Copy link
Copy Markdown
Member

@beauby please update _format/1.1/index.md as well

@beauby beauby force-pushed the 404-create-missing-related branch from c3f6671 to 8cd108e Compare September 28, 2016 21:30
@beauby

beauby commented Sep 28, 2016

Copy link
Copy Markdown
Contributor Author

@dgeb Done as well.

@dgeb

dgeb commented Sep 28, 2016

Copy link
Copy Markdown
Member

@beauby Thanks again. LGTM.

@ethanresnick Please review.

@ethanresnick

Copy link
Copy Markdown
Member

LGTM too. Merged! Thanks @beauby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants