-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response status for POST with inexistent related resource. #1036
Add response status for POST with inexistent related resource. #1036
Conversation
I agree that this should be spelled out under creating resources, as it is under updating resources (see http://jsonapi.org/format/#crud-updating-responses-404). We need to decide if this should land in 1.0, 1.1, or both. |
Anything more I can do to help on this one? |
@beauby I've labeled this as needing further discussion because of the MUST. |
Fair enough – my understanding was that this was highly implied by the spirit of the spec, but forgotten to be clearly spelled out. |
I agree. I think this change is entirely consistent with the "updating resources" section, and I am not really in favor of downgrading the MUST because its omission was just an oversight. |
I trust @dgeb's judgement re adding the MUST. Re landing in 1.0, 1.1 or both...to date, we've been pretty loose about backporting things to 1.0, and I don't think that's been a problem. If we want to get stricter at some point about the published versions being immutable artifacts, we can, but I'm not sure what the value of that would be now. Regardless, @beauby please update this pr so that it changes the normative-statements.json files as well. (See e.g. #1102.) |
@ethanresnick Done. |
@beauby please update _format/1.1/index.md as well |
c3f6671
to
8cd108e
Compare
@dgeb Done as well. |
@beauby Thanks again. LGTM. @ethanresnick Please review. |
LGTM too. Merged! Thanks @beauby |
related: #1033