New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit fallthrough detected by gcc 7.1 #323

Closed
wongsyrone opened this Issue May 7, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@wongsyrone

wongsyrone commented May 7, 2017

json_object.c: In function 'json_object_get_int64':
json_object.c:554:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
  if (json_parse_int64(jso->o.c_string.str, &cint) == 0) return cint;
     ^
json_object.c:555:3: note: here
   default:
   ^~~~~~~

@commodo

This comment has been minimized.

Show comment
Hide comment
@commodo

commodo Jun 15, 2017

Contributor

@wongsyrone
I think you are referencing an older version [ the released one ].
The code in this repo is pretty far ahead of that released version.

This has been addressed in this commit : 014924b

Maybe, feel free to backport it :)

Contributor

commodo commented Jun 15, 2017

@wongsyrone
I think you are referencing an older version [ the released one ].
The code in this repo is pretty far ahead of that released version.

This has been addressed in this commit : 014924b

Maybe, feel free to backport it :)

@wongsyrone

This comment has been minimized.

Show comment
Hide comment
@wongsyrone

wongsyrone Jun 15, 2017

Yes. We are using json-c-0.12.1. I'm closing this and wait for the next release.

wongsyrone commented Jun 15, 2017

Yes. We are using json-c-0.12.1. I'm closing this and wait for the next release.

@wongsyrone wongsyrone closed this Jun 15, 2017

@commodo

This comment has been minimized.

Show comment
Hide comment
@commodo

commodo Jun 15, 2017

Contributor

There's issue #314
Maybe add a vote to ? :p

Contributor

commodo commented Jun 15, 2017

There's issue #314
Maybe add a vote to ? :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment