Skip to content

Conversation

@mike-marcacci
Copy link
Contributor

It looks like the ObjectPath dependency was breaking angular-schema-form installs in environments that use require.js (see mike-marcacci/objectpath#1), because ObjectPath couldn't automatically register itself with angular. I've removed the auto-registration in a new version of ObjectPath, and this PR fixes the issue accordingly.

I don't use either AMD or require.js in my schema-form projects, so maybe @frhd or @skchrko can check this out?

Please note that this requires users to upgrade ObjectPath to 1.1 when they upgrade ASF (assuming they aren't using bower).

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling eb78488 on mike-marcacci:fix/requirejs-objectpath-issue into a313ef6 on Textalk:development.

@frhd
Copy link

frhd commented Nov 13, 2014

@mike-marcacci As mentioned in mike-marcacci/objectpath#1 (comment), I had no issues with this PR build and ObjectPath 1.1 and an AMD wrapped schema-form. Webjar should be availabe soon.

@mike-marcacci
Copy link
Contributor Author

bump :)

davidlgj added a commit that referenced this pull request Dec 18, 2014
…ssue

Use objectpath more generically to fix requirejs issues
@davidlgj davidlgj merged commit 22aa1d6 into json-schema-form:development Dec 18, 2014
@davidlgj
Copy link
Contributor

Hey, thanks for the PR and sorry that I kept it hanging :-)

@GerardSoleCa
Copy link

Hi,

I have a project that it was pointing to the dev branch. Two hours and a bit ago the project was working. Sudently, all our angular frontend was broken. Changing to 0.7.6 (master) is working fine again.

Link error (althougth I think that doesn't provide enought information): http://tinyurl.com/qdqctuu

Thanks! :)

@davidlgj
Copy link
Contributor

Hi @GerardSoleCa, thanks for the heads up!

Going against dev branch directly without building it yourself can be a bit dangerous, it's not meant to be "bowered". There is no guarantee that the built files in dist is up to date and I believe this is what got broken for you. I think the ObjectPath lib got updated, but you had the old dist files. I updated them so I think it should be fine, but it will happen again :-)

@mike-marcacci
Copy link
Contributor Author

Hi @davidlgj – thanks for the merge and no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants