feat(php): Add PHP SDK implementation #7

Copilot · 2025-12-06T08:55:48Z

Original prompt

This section details on the original issue you should resolve

<issue_title>feat(php): Add PHP SDK implementation</issue_title>
<issue_description>## Summary

Add a PHP SDK for JSON Structure schema and instance validation.

Background

PHP powers approximately 77% of websites with a known server-side language. With Laravel, Symfony, and WordPress dominating web development, a PHP SDK provides schema validation for the massive PHP ecosystem including:

Laravel/Symfony API validation

WordPress plugin data validation

Composer package ecosystem

Legacy PHP application modernization

Implementation Guide

Follow the SDK Guidelines document: SDK-GUIDELINES.md

This document contains:

Required components (SchemaValidator, InstanceValidator, ErrorCodes, JsonSourceLocator)

Complete type system reference (34 primitive types + compound types)

Keywords reference (what to implement, what NOT to implement)

Error codes reference (assets/error-messages.json)

Test assets for conformance testing

Conformance checklist

Requirements

Core Features

Schema Validation: Validate JSON Structure schema documents for conformance

Instance Validation: Validate JSON instances against JSON Structure schemas

Error Reporting: Line/column information for validation errors (when source JSON available)

Full Type Support: All 34 primitive and compound types from JSON Structure Core v0

Technical Requirements

PHP 8.1+ (for modern type system, enums, readonly properties)

Composer for distribution

Use json_decode() / json_encode() for JSON parsing

PSR-4 autoloading

PHPUnit for testing

No framework dependencies (pure PHP, works with any framework)

Package Structure
php/
 composer.json
 README.md
 phpunit.xml
 src/
    JsonStructure/
        SchemaValidator.php
        InstanceValidator.php
        Types.php
        ErrorCodes.php
        JsonSourceLocator.php
        ValidationResult.php
 tests/
     SchemaValidatorTest.php
     InstanceValidatorTest.php
     TestAssets.php
CI/CD

GitHub Actions workflow with PHP matrix (8.1, 8.2, 8.3)

Test on ubuntu-latest

Integration with shared test-assets/ for cross-SDK validation

Reference Materials

SDK Guidelines: SDK-GUIDELINES.md - Start here

Error Messages: assets/error-messages.json

Test Assets: test-assets/

Meta-schemas: meta/

Reference implementations: go/, rust/, typescript/, python/

Acceptance Criteria

All test-assets pass validation

CI workflow passes on PHP 8.1, 8.2, 8.3

README with installation and usage examples

Conformance checklist completed (see SDK-GUIDELINES.md)

Published to Packagist (or ready for publication)
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes feat(php): Add PHP SDK implementation #5

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

clemensv · 2025-12-06T09:40:49Z

@copilot investigate the test failures. your test coverage must be improved. you need to achieve 85% coverage and your feature tests must be on par with the test set of C# (over 500 test cases including validation of all schemas and instances in /test-assets)

Copilot · 2025-12-06T10:27:14Z

@copilot investigate the test failures. your test coverage must be improved. you need to achieve 85% coverage and your feature tests must be on par with the test set of C# (over 500 test cases includi...

I've addressed the test coverage requirements:

Added 585 tests (compared to previous 229)
Achieved 85.52% line coverage (exceeds the 85% requirement)
Test files include comprehensive validation for all types, composition keywords, format validation, and edge cases

Key commits: a3c3688, 7dda624, 7691f07

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/sebastianbergmann/exporter/zipball/70a298763b40b213ec087c51c739efcaa90bcd74
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/YB90BR /usr/bin/composer install --prefer-dist --no-progress (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
https://api.github.com/repos/sebastianbergmann/global-state/zipball/3be331570a721f9a4b5917f4209773de17f747d7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/YB90BR /usr/bin/composer install --prefer-dist --no-progress (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/f5b498e631a74204185071eb41f33f38d64608aa
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/YB90BR /usr/bin/composer install --prefer-dist --no-progress (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/6e1a43b411b2ad34146dee7524cb13a068bb35f9
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/LojIM8 /usr/bin/composer install --prefer-dist DROP (http block)
https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/f6458abbf32a6c8174f8f26261475dc133b3d9dc
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/LojIM8 /usr/bin/composer install --prefer-dist DROP (http block)
https://api.github.com/repos/sebastianbergmann/type/zipball/f77d2d4e78738c98d9a68d2596fe5e8fa380f449
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/LojIM8 /usr/bin/composer install --prefer-dist DROP (http block)
https://api.github.com/repos/sebastianbergmann/version/zipball/c687e3387b99f5b03b6caa64c74b63e2936ff874
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/YB90BR /usr/bin/composer install --prefer-dist --no-progress (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)
https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/YB90BR /usr/bin/composer install --prefer-dist --no-progress (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/HE3wiI /usr/bin/composer install (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/vchN8O /usr/bin/composer require phpunit/phpunit --dev (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

clemensv · 2025-12-06T17:02:29Z

@copilot why is the PHP 8.1 test failing?

Copilot · 2025-12-06T17:08:27Z

@copilot why is the PHP 8.1 test failing?

The PHP 8.1 test was failing because readonly class is a PHP 8.2+ feature. PHP 8.1 only supports readonly on individual properties, not the entire class. Fixed in commit 0f22899 by changing readonly class JsonLocation to class JsonLocation with readonly on each property declaration.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/sebastianbergmann/exporter/zipball/70a298763b40b213ec087c51c739efcaa90bcd74
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/NYZXCb /usr/bin/composer install --prefer-dist --no-progress (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/sebastianbergmann/global-state/zipball/3be331570a721f9a4b5917f4209773de17f747d7
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/f5b498e631a74204185071eb41f33f38d64608aa
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/6e1a43b411b2ad34146dee7524cb13a068bb35f9
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/f6458abbf32a6c8174f8f26261475dc133b3d9dc
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/sebastianbergmann/type/zipball/f77d2d4e78738c98d9a68d2596fe5e8fa380f449
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/sebastianbergmann/version/zipball/c687e3387b99f5b03b6caa64c74b63e2936ff874
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)
https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/oCj7p1 /usr/bin/composer install --prefer-dist --no-progress (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

…t clarity Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

…rties Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Implements patternKeys validation for map types to achieve C# parity. When a map schema has a patternKeys property with a pattern constraint, all map keys are validated to match the regex pattern. - Added patternKeys validation in validateValidationAddins() - Added test for valid and invalid map keys with patternKeys Tests: 441 passing (excluding TestAssets tests that require full SDK structure)

… extension warnings - Added testWarningSchemaIsValidButProducesWarnings test method - Tests all 24 schemas in test-assets/schemas/warnings/ - Added patternProperties extension keyword warning check - Added propertyNames extension keyword warning check Tests: 610 passing (with full test-assets mounted)

Copilot AI assigned Copilot and clemensv Dec 6, 2025

Copilot started work on behalf of clemensv December 6, 2025 08:56 View session

Copilot AI changed the title ~~[WIP] Add PHP SDK for JSON structure validation~~ feat(php): Add PHP SDK implementation Dec 6, 2025

Copilot AI requested a review from clemensv December 6, 2025 09:32

Copilot finished work on behalf of clemensv December 6, 2025 09:32

Copilot started work on behalf of clemensv December 6, 2025 09:41 View session

Copilot finished work on behalf of clemensv December 6, 2025 10:30

Copilot started work on behalf of clemensv December 6, 2025 17:02 View session

Copilot finished work on behalf of clemensv December 6, 2025 17:09

clemensv marked this pull request as ready for review December 7, 2025 17:17

clemensv force-pushed the copilot/add-php-sdk-implementation branch from f9ed06e to b750c39 Compare December 7, 2025 22:14

Copilot AI and others added 12 commits December 7, 2025 23:20

Initial plan

d078183

Add PHP SDK implementation with all core features

029dc2f

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Add test assets integration tests and fix .gitignore for PHP

504f762

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Address code review feedback and fix workflow permissions

0793de4

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Add 510 tests to PHP SDK for improved code coverage (83.62%)

bec7b11

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Achieve 85%+ test coverage for PHP SDK (585 tests, 85.52% coverage)

4bbdd63

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Address code review feedback - fix PHPUnit version constraint and tes…

17214ec

…t clarity Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

21ba1d8

Fix PHP 8.1 compatibility: replace readonly class with readonly prope…

dd887d8

…rties Co-authored-by: clemensv <542030+clemensv@users.noreply.github.com>

docs: Add PHP SDK to README

805be9b

clemensv force-pushed the copilot/add-php-sdk-implementation branch from b750c39 to 805be9b Compare December 7, 2025 22:22

clemensv merged commit 7fdaaa6 into master Dec 7, 2025
3 checks passed

clemensv deleted the copilot/add-php-sdk-implementation branch December 7, 2025 22:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(php): Add PHP SDK implementation #7

feat(php): Add PHP SDK implementation #7

Uh oh!

Copilot AI commented Dec 6, 2025 •

edited

Loading

Uh oh!

clemensv commented Dec 6, 2025

Uh oh!

Copilot AI commented Dec 6, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

clemensv commented Dec 6, 2025

Uh oh!

Copilot AI commented Dec 6, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(php): Add PHP SDK implementation #7

feat(php): Add PHP SDK implementation #7

Uh oh!

Conversation

Copilot AI commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Background

Implementation Guide

Requirements

Core Features

Technical Requirements

Package Structure

CI/CD

Reference Materials

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

clemensv commented Dec 6, 2025

Uh oh!

Copilot AI commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

clemensv commented Dec 6, 2025

Uh oh!

Copilot AI commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 6, 2025 •

edited

Loading

Copilot AI commented Dec 6, 2025 •

edited

Loading

Copilot AI commented Dec 6, 2025 •

edited

Loading