Add hook for automatic pagination links. #35
Conversation
lib/jsonapi/rails/railtie.rb
Outdated
|
|
||
| # Renderer proc is evaluated in the controller context, so it | ||
| # has access to the jsonapi_pagination method. | ||
| if pagination_links = jsonapi_pagination(resources) |
There was a problem hiding this comment.
Assignment in condition - you probably meant to use ==.
| end | ||
| end | ||
|
|
||
| def jsonapi_pagination(collection) |
There was a problem hiding this comment.
Unused method argument - collection. If it's necessary, use _ or _collection as an argument name to indicate that it won't be used. You can also write as jsonapi_pagination(*) if you want the method to accept any arguments but don't care about them.
| { "#{key}_id".to_sym => id, "#{key}_type".to_sym => type } | ||
| end | ||
| has_many do |_rel, ids, types, key| | ||
| key = key.to_s.singularize |
There was a problem hiding this comment.
Unnecessary spacing detected.
Operator = should be surrounded by a single space.
| module JSONAPI | ||
| module Rails | ||
| module Deserializable | ||
| class Resource < JSONAPI::Deserializable::Resource |
There was a problem hiding this comment.
Missing top-level class documentation comment.
lib/jsonapi/rails/railtie.rb
Outdated
|
|
||
| # Renderer proc is evaluated in the controller context, so it | ||
| # has access to the jsonapi_pagination method. | ||
| if pagination_links = jsonapi_pagination(resources) |
There was a problem hiding this comment.
Assignment in condition - you probably meant to use ==.
| end | ||
| end | ||
|
|
||
| def jsonapi_pagination(collection) |
There was a problem hiding this comment.
Unused method argument - collection. If it's necessary, use _ or _collection as an argument name to indicate that it won't be used. You can also write as jsonapi_pagination(*) if you want the method to accept any arguments but don't care about them.
| { "#{key}_id".to_sym => id, "#{key}_type".to_sym => type } | ||
| end | ||
| has_many do |_rel, ids, types, key| | ||
| key = key.to_s.singularize |
There was a problem hiding this comment.
Unnecessary spacing detected.
Operator = should be surrounded by a single space.
| module JSONAPI | ||
| module Rails | ||
| module Deserializable | ||
| class Resource < JSONAPI::Deserializable::Resource |
There was a problem hiding this comment.
Missing top-level class documentation comment.
beauby
force-pushed
the
pagination
branch
2 times, most recently
from
611b060 to
c763af2
Compare
* upstream/master: Conditionally include controller mixin (jsonapi-rb#40) Add initializer generator. (jsonapi-rb#39) Add ActiveSupport::Notifications instrumentation. (jsonapi-rb#41) Add library configuration object (jsonapi-rb#17) Rename JSONAPI::Rails::ActionController to JSONAPI::Rails::Controller. (jsonapi-rb#38) Add hook for default jsonapi object. (jsonapi-rb#37) Add hook for default exposures. (jsonapi-rb#36) Add hook for automatic pagination links. (jsonapi-rb#35) Upgrade to new jsonapi-deserializable version. (jsonapi-rb#34) Prepare for v0.2.1 release
Closes #28. On top of #34.
Introduces a
jsonapi_paginationhook inActionController::Basethat can be used to inject a hash of pagination links.Example: