Skip to content

Conversation

@beauby
Copy link
Member

@beauby beauby commented Jul 15, 2017

On top of #36.

module JSONAPI
module Rails
module Deserializable
class Resource < JSONAPI::Deserializable::Resource

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.

'id' => '1',
'type' => 'users',
'attributes' => { 'name' => 'Lucas' }
describe '#render' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [49/25]

serializer = Class.new(JSONAPI::Serializable::Resource) do
type :users
attribute :name
describe '#render' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [49/25]

@beauby beauby mentioned this pull request Jul 25, 2017
@beauby beauby merged commit 0d84b02 into master Jul 25, 2017
@beauby beauby deleted the jsonapi_object branch July 25, 2017 08:11
mdeutsch pushed a commit to patientslikeme/jsonapi-rails that referenced this pull request Jul 25, 2017
* upstream/master:
  Conditionally include controller mixin (jsonapi-rb#40)
  Add initializer generator. (jsonapi-rb#39)
  Add ActiveSupport::Notifications instrumentation. (jsonapi-rb#41)
  Add library configuration object (jsonapi-rb#17)
  Rename JSONAPI::Rails::ActionController to JSONAPI::Rails::Controller. (jsonapi-rb#38)
  Add hook for default jsonapi object. (jsonapi-rb#37)
  Add hook for default exposures. (jsonapi-rb#36)
  Add hook for automatic pagination links. (jsonapi-rb#35)
  Upgrade to new jsonapi-deserializable version. (jsonapi-rb#34)
  Prepare for v0.2.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants