Skip to content

Conversation

@beauby
Copy link
Member

@beauby beauby commented Jul 25, 2017

No description provided.

@@ -0,0 +1,5 @@
JSONAPI::Rails.configure do |config|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

source_root File.expand_path('../templates', __FILE__)

def copy_initializer_file
copy_file 'initializer.rb', "config/initializers/jsonapi.rb"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@@ -0,0 +1,7 @@
class InitializerGenerator < Rails::Generators::Base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.
Missing magic comment # frozen_string_literal: true.

@@ -0,0 +1,5 @@
JSONAPI::Rails.configure do |config|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

source_root File.expand_path('../templates', __FILE__)

def copy_initializer_file
copy_file 'initializer.rb', "config/initializers/jsonapi.rb"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@@ -0,0 +1,7 @@
class InitializerGenerator < Rails::Generators::Base

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing top-level class documentation comment.
Missing magic comment # frozen_string_literal: true.

@beauby beauby changed the title Add initializer generator. [WIP] Add initializer generator. Jul 25, 2017
@beauby beauby force-pushed the initializer-generator branch from b8cce14 to c2a0f8d Compare July 25, 2017 11:17
@beauby beauby changed the title [WIP] Add initializer generator. Add initializer generator. Jul 25, 2017
@beauby beauby merged commit a904687 into master Jul 25, 2017
@beauby beauby deleted the initializer-generator branch July 25, 2017 11:18
mdeutsch pushed a commit to patientslikeme/jsonapi-rails that referenced this pull request Jul 25, 2017
* upstream/master:
  Conditionally include controller mixin (jsonapi-rb#40)
  Add initializer generator. (jsonapi-rb#39)
  Add ActiveSupport::Notifications instrumentation. (jsonapi-rb#41)
  Add library configuration object (jsonapi-rb#17)
  Rename JSONAPI::Rails::ActionController to JSONAPI::Rails::Controller. (jsonapi-rb#38)
  Add hook for default jsonapi object. (jsonapi-rb#37)
  Add hook for default exposures. (jsonapi-rb#36)
  Add hook for automatic pagination links. (jsonapi-rb#35)
  Upgrade to new jsonapi-deserializable version. (jsonapi-rb#34)
  Prepare for v0.2.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants