Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for custom attribute with condition #108

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Add example for custom attribute with condition #108

merged 1 commit into from
Aug 7, 2020

Conversation

dcangulo
Copy link
Contributor

@dcangulo dcangulo commented Aug 7, 2020

What is the current behavior?

There is no example when using custom attributes with condition.

What is the new behavior?

Added an example when using custom attributes with condition.
Closes #107

Checklist

Please make sure the following requirements are complete:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes /
    features)
  • All automated checks pass (CI/CD)

@stas
Copy link
Collaborator

stas commented Aug 7, 2020

Thank you @dcangulo

I'll take care of the tests, looks like a side-effect after the recent changes in the rspec-jsonapi gem.

🙇

@stas stas merged commit 0e051fc into jsonapi-serializer:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing condition for custom attribute documentation
2 participants