New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module map file to targets other than iOS #583

Merged
merged 1 commit into from Apr 29, 2017

Conversation

Projects
None yet
2 participants
@zoul
Contributor

zoul commented Apr 28, 2017

In #482 a module map file was added that fixed an issue when installing
JSONModel with Carthage. But it seems to me that the fix was only applied
to the iOS target (or maybe the other targets were only added later?),
which means I can still see the issue when trying to install on macOS:

<module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONAPI.h' [-Werror,-Wincomplete-umbrella]
#import "Headers/JSONModel.h"
^
<module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONHTTPClient.h' [-Werror,-Wincomplete-umbre
<module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONModel+networking.h' [-Werror,-Wincomplete
<module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONModelLib.h' [-Werror,-Wincomplete-umbrell
4 errors generated.

This change adds the module map from #482 to all targets.

Add module map file to targets other than iOS
In #482 a module map file was added that fixed an issue when installing
JSONModel with Carthage. But it seems to me that the fix was only applied
to the iOS target (or maybe the other targets were only added later?),
which means I can still see the issue when trying to install on macOS:

    <module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONAPI.h' [-Werror,-Wincomplete-umbrella]
    #import "Headers/JSONModel.h"
    ^
    <module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONHTTPClient.h' [-Werror,-Wincomplete-umbre
    <module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONModel+networking.h' [-Werror,-Wincomplete
    <module-includes>:1:1: error: umbrella header for module 'JSONModel' does not include header 'JSONModelLib.h' [-Werror,-Wincomplete-umbrell
    4 errors generated.

This change adds the module map from #482 to all targets.

@billinghamj billinghamj merged commit 1e80eca into jsonmodel:master Apr 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@billinghamj

This comment has been minimized.

Show comment
Hide comment
Member

billinghamj commented Apr 29, 2017

Thanks @zoul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment