It turns out there were a lot of these.
…php4 any more. No functional change.
packages when they switched to use bundled files in php-5.2.9. Now we don't need this workaround any more and code itself already no operation. No functional change.
This changes the buildlink3.mk files to use an include guard for the recursive include. The use of BUILDLINK_DEPTH, BUILDLINK_DEPENDS, BUILDLINK_PACKAGES and BUILDLINK_ORDER is handled by a single new variable BUILDLINK_TREE. Each buildlink3.mk file adds a pair of enter/exit marker, which can be used to reconstruct the tree and to determine first level includes. Avoiding := for large variables (BUILDLINK_ORDER) speeds up parse time as += has linear complexity. The include guard reduces system time by avoiding reading files over and over again. For complex packages this reduces both %user and %sys time to half of the former time.
components are now built into PHP rather than maintained separately in PECL. The old PECL versions are unmaintained and haven't been altered for 3 years. This is confusing as the package versions report themselves to be 18.104.22.168.0.2, etc. but they are in fact based on the 5.1.x code-base. Therefore, we need to switch to building the PDO modules like any other PHP module. A side-effect of this is that the PECL version number will get stripped off the end meaning that the new version numbers are just 5.2.9 instead of 22.214.171.124.0.2 (for example). Unfortunately, 5.2.9 is considered to be older than 126.96.36.199.0.2 meaning that it will appear as though a downgrade has taken place. Therefore, while we are still using PHP 5.2.9, add .99 on the end (i.e. 188.8.131.52) so that the package appears newer. When PHP 5.2.10 is released this can be removed (the module.mk file explicitly cgecks for 5.2.9 before adding the .99 suffix so that it will not alter 5.2.10 if the hack is forgotten. However, for the record, when 5.2.10 is released, php-pdo/module.mk can be removed along with the references to it in each php-pdo*/Makefile
up the packages that use it instead.
…well, and add a new helper target and script, "show-buildlink3", that outputs a listing of the buildlink3.mk files included as well as the depth at which they are included. For example, "make show-buildlink3" in fonts/Xft2 displays: zlib fontconfig iconv zlib freetype2 expat freetype2 Xrender renderproto
of the order in which buildlink3.mk files are (recursively) included by a package Makefile.
all PEAR packages to php?-pear-* and all Apache packages to ap13-* or ap2-* respectively. Add new variables to simplify the Makefile handling. Add CONFLICTS on the old names. Reset revisions of bumped packages. ap-php will now depend on the default Apache and PHP version. All programs using it have an implicit option of the Apache version as well. OK from jlam@ and adrianp@.
RECOMMENDED is removed. It becomes ABI_DEPENDS. BUILDLINK_RECOMMENDED.foo becomes BUILDLINK_ABI_DEPENDS.foo. BUILDLINK_DEPENDS.foo becomes BUILDLINK_API_DEPENDS.foo. BUILDLINK_DEPENDS does not change. IGNORE_RECOMMENDED (which defaulted to "no") becomes USE_ABI_DEPENDS which defaults to "yes". Added to obsolete.mk checking for IGNORE_RECOMMENDED. I did not manually go through and fix any aesthetic tab/spacing issues. I have tested the above patch on DragonFly building and packaging subversion and pkglint and their many dependencies. I have also tested USE_ABI_DEPENDS=no on my NetBSD workstation (where I have used IGNORE_RECOMMENDED for a long time). I have been an active user of IGNORE_RECOMMENDED since it was available. As suggested, I removed the documentation sentences suggesting bumping for "security" issues. As discussed on tech-pkg. I will commit to revbump, pkglint, pkg_install, createbuildlink separately. Note that if you use wip, it will fail! I will commit to pkgsrc-wip later (within day).
Changes are bugfixes mostly. Also rework php-pdo/module.mk somewhat, so that the base php-pdo package can use it too.
object-oriented interface to various databases. PDO comes bundled with upcoming PHP 5.1, but can also be used with PHP 5.0 via PECL.