Skip to content

Conversation

@acao
Copy link
Collaborator

@acao acao commented Jul 30, 2023

@imolorhe here i've extracted much of the test coverage from #48 so we can catch regressions after the json5 completion tweaks

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2023

⚠️ No Changeset found

Latest commit: c129050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 30, 2023

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit c129050
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/64c638445f01350008415132
😎 Deploy Preview https://deploy-preview-51--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

type: "property",
detail: "",
info: "an example enum with default bar",
// TODO: should this not autocomplete to default "bar"?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what I was referring to with completion of default enum value, this is why i added the if/else block in #48

@acao acao merged commit 5fcf5ad into main Aug 3, 2023
@acao acao deleted the more-tests branch August 3, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants