Bump json-schema/JSON-Schema-Test-Suite to 1.2.0 + some tests improvements #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done:
file.json / suite description / test case descriptionFailing tests output before the change:
Failing tests output after the change:
It uses description fields from suite and test case. This may seem an overkill, but it really simplifies hunting for the test to fix when you have a readable path.
json-schema/JSON-Schema-Test-Suiteto1.2.0. Pay attention here, important:If we really want to state which version of the draft the validator follows, we need to compare against the newest available version. I presume everyone agrees ;) So,
1.2.0bring three failure specs:format.json/Draft 3/ optionalformat.json/Draft 4/ optionalnot.json/Draft 4/ requiredSad thing, there is no mechanism to skip one test case from
not.json. For the time being, I've skipped the whole file as it's now my priority to fix that case as it's required by spec. Still, I think it doesn't hurt us as I doubt people are going to dig tests to see the compliance with spec (I'm working on documenting that)./cc @bighappyface