New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button outline #181

Open
RavanH opened this Issue Jul 7, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@RavanH
Contributor

RavanH commented Jul 7, 2018

Hi, I'm not an expert but I think for accessibility reasons the style rule outline:none for .lity-close and .lity-close:focus should be removed.

@jsor

This comment has been minimized.

Show comment
Hide comment
@jsor

jsor Jul 7, 2018

Owner

👍 Feel free top open a PR

Owner

jsor commented Jul 7, 2018

👍 Feel free top open a PR

@RavanH

This comment has been minimized.

Show comment
Hide comment
@RavanH

RavanH Jul 7, 2018

Contributor

Sure :)

Related question: there seem to be a lot of "double" css rules that appear both for .lity-close and .lity-close:hoverfocus/active/visited (except text-decoration:none) that could be removed. Or is there a special reason to keep them in both?

Contributor

RavanH commented Jul 7, 2018

Sure :)

Related question: there seem to be a lot of "double" css rules that appear both for .lity-close and .lity-close:hoverfocus/active/visited (except text-decoration:none) that could be removed. Or is there a special reason to keep them in both?

@jsor

This comment has been minimized.

Show comment
Hide comment
@jsor

jsor Jul 7, 2018

Owner

Not sure what you mean exactly, but feel free to open another PR to discuss this.

Owner

jsor commented Jul 7, 2018

Not sure what you mean exactly, but feel free to open another PR to discuss this.

@RavanH

This comment has been minimized.

Show comment
Hide comment
@RavanH

RavanH Jul 7, 2018

Contributor

Oh, hang on... this is not the case in current development. I was referring to 2.3.1. Never mind :)

Contributor

RavanH commented Jul 7, 2018

Oh, hang on... this is not the case in current development. I was referring to 2.3.1. Never mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment