New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanging on Loading when in mobile only #196

Open
john-Graham opened this Issue Sep 5, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@john-Graham

john-Graham commented Sep 5, 2018

I'm trying to sort out if I'm having a lity issue, a conflict or other. What's happening is when I load on mobile, I get the black background and the word loading but it hangs on there and the console is showing...

Uncaught TypeError: Cannot read property 'on' of undefined
at new x (lity-min.js:5)
at HTMLAnchorElement.y (lity-min.js:5)

specifically starting at: (.on("click","[data-lity-close]",

I'm on jQuery 1.12.1 so I'm not sure there's any dependency issues.

I have the page up and would be curious if you have any thoughts. https://www.edgewood.edu/admissions/freshman-students

@jsor

This comment has been minimized.

Show comment
Hide comment
@jsor

jsor Sep 6, 2018

Owner

You're probably calling on() on a HTMLElement, not on a jQuery instance. You must ensure to wrap the element like $(element).on(...) instead of element.on(...).

Owner

jsor commented Sep 6, 2018

You're probably calling on() on a HTMLElement, not on a jQuery instance. You must ensure to wrap the element like $(element).on(...) instead of element.on(...).

@john-Graham

This comment has been minimized.

Show comment
Hide comment
@john-Graham

john-Graham Sep 7, 2018

I'm not calling it programmatically, just added the data attribute.
<a href="https://www.youtube.com/watch?v=vR1hyPDep3U" data-lity> <div class="btn white">Meet Kourtni</div> </a>

Also tried
<div class="btn white" data-lity data-lity-target="https://www.youtube.com/watch?v=vR1hyPDep3U">Meet Kourtni</div>

I'll try doing it programmatically and see if that makes a difference.

john-Graham commented Sep 7, 2018

I'm not calling it programmatically, just added the data attribute.
<a href="https://www.youtube.com/watch?v=vR1hyPDep3U" data-lity> <div class="btn white">Meet Kourtni</div> </a>

Also tried
<div class="btn white" data-lity data-lity-target="https://www.youtube.com/watch?v=vR1hyPDep3U">Meet Kourtni</div>

I'll try doing it programmatically and see if that makes a difference.

@john-Graham

This comment has been minimized.

Show comment
Hide comment
@john-Graham

john-Graham Sep 10, 2018

Same issue when calling it through the console. Interestingly it's working on the newest Android OS and on iPhone if you do the force touch it will work. Baffling.

john-Graham commented Sep 10, 2018

Same issue when calling it through the console. Interestingly it's working on the newest Android OS and on iPhone if you do the force touch it will work. Baffling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment