This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Fix warning in ext_getPropertyAccessorsForClass #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nope, this was probably just a typo. Thanks for the pull request! |
jspahrsummers
added a commit
that referenced
this pull request
Aug 24, 2014
Fix warning in ext_getPropertyAccessorsForClass
|
Would it be too much trouble to do a cocoa pods release with this commit? If not, it's not the end of the world. Thanks! |
|
Sure, just tagged 0.4.1, though I don't control the podspec. |
|
@jspahrsummers if you want it, you should claim the podspec. Whoever it is that currently owns it is not updating it. |
|
I don't use CocoaPods myself, so there probably isn't much value in me maintaining the podspec. |
|
It's just metadata. You should consider it. |
|
Actually, it's full of subspecs, so I guess this one requires someone familiar with pods. |
diederich
added a commit
to cocologics/libextobjc
that referenced
this pull request
Jun 28, 2017
Submodule changes to be committed: * Configuration c8e5527...4ac967d (12): > Merge pull request jspahrsummers#80 from cocologics/feature/xcode9-update > Merge pull request jspahrsummers#79 from cocologics/feature/xcode9-update > Merge pull request jspahrsummers#71 from fabb/analyzer_localized > enable CLANG_ANALYZER_NONNULL > enable CLANG_WARN_NULLABLE_TO_NONNULL_CONVERSION > enables SWIFT_TREAT_WARNINGS_AS_ERRORS > Merge pull request jspahrsummers#67 from fabb/enable_nullability_completeness_warning > Merge pull request jspahrsummers#65 from Abizern/xcode8_debug_flag > Merge pull request jspahrsummers#64 from diederich/enableTestability > Merge pull request jspahrsummers#63 from diederich/implicitCaptureOfSelf > Merge pull request jspahrsummers#62 from calebd/xcode-8-beta-5-warnings > Merge pull request jspahrsummers#61 from ikesyo/disable-framework-codesigning
diederich
added a commit
that referenced
this pull request
Jul 14, 2017
* bumped the xcconfigs to latest version
* fix build on Xcode 9 ('void' missing in strict declaration checking)
Submodule changes to be committed:
* Configuration c8e5527...4ac967d (12):
> Merge pull request #80 from cocologics/feature/xcode9-update
> Merge pull request #79 from cocologics/feature/xcode9-update
> Merge pull request #71 from fabb/analyzer_localized
> enable CLANG_ANALYZER_NONNULL
> enable CLANG_WARN_NULLABLE_TO_NONNULL_CONVERSION
> enables SWIFT_TREAT_WARNINGS_AS_ERRORS
> Merge pull request #67 from fabb/enable_nullability_completeness_warning
> Merge pull request #65 from Abizern/xcode8_debug_flag
> Merge pull request #64 from diederich/enableTestability
> Merge pull request #63 from diederich/implicitCaptureOfSelf
> Merge pull request #62 from calebd/xcode-8-beta-5-warnings
> Merge pull request #61 from ikesyo/disable-framework-codesigning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting the following warning in Xcode 6 beta 6:
My understanding is limited, but it seems as though
attributesis no longer used after thefree(attributes)line. My changes fix the warning, but would this change have any unintended consequences? I ran the tests and they pass (though they fail to compile without the fix due to the warning).