From 1393816ecad22854bea92d21aae58f2b39d1a8f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Konstantin=20Bl=C3=A4si?= Date: Sat, 22 Jul 2017 03:07:30 +0200 Subject: [PATCH 1/2] Fix tests not being saved when editing an existing page. Fixes #236 --- server/repositories/tests.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/repositories/tests.js b/server/repositories/tests.js index c3dd1b66..2f451c85 100644 --- a/server/repositories/tests.js +++ b/server/repositories/tests.js @@ -38,7 +38,7 @@ exports.register = function (server, options, next) { } // ... otherwise skip over the test } else { - if (test.testID) { + if (isOwn && test.testID) { queries.push(db.genericQuery(`UPDATE ?? SET title = ${db.escape(test.title)}, defer = ${db.escape(test.defer)} , code = ${db.escape(test.code)} WHERE pageID = ${pageID} AND testID = ${test.testID}`, [table])); } else { queries.push(db.genericQuery(`INSERT INTO ?? (??) VALUES (${pageID}, ${db.escape(test.title)}, ${db.escape(test.defer)}, ${db.escape(test.code)})`, [table, columns])); From 962c6a3c3f30dff6f5527e156bed35e685e3b45f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Konstantin=20Bl=C3=A4si?= Date: Sat, 22 Jul 2017 03:11:11 +0200 Subject: [PATCH 2/2] Set isOwner to true, since only the creator of a revision is allowed to edit it. --- test/unit/server/repositories/tests.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/server/repositories/tests.js b/test/unit/server/repositories/tests.js index 01f5246d..ecbef3f7 100644 --- a/test/unit/server/repositories/tests.js +++ b/test/unit/server/repositories/tests.js @@ -173,7 +173,7 @@ lab.experiment('Tests Repository', function () { let tClone = Hoek.clone(t); tClone[0].testID = 123; tClone[1].testID = 321; - tests.bulkUpdate(pageID, tClone, false) + tests.bulkUpdate(pageID, tClone, true) .then(results => { const call1 = genericQueryStub.getCall(0).args; const call2 = genericQueryStub.getCall(1).args;