New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package override for isteven omni bar #388

Merged
merged 1 commit into from May 22, 2015

Conversation

Projects
None yet
2 participants
@XVincentX
Contributor

XVincentX commented May 19, 2015

This PR should add the required overrides for isteven-angular-omnibar

@guybedford

This comment has been minimized.

Member

guybedford commented May 19, 2015

This repo doesn't seem to exist? https://github.com/angular-omni-bar/isteven-angular-omni-bar?

Note that the name is not used in jspm, as we don't provide a publishing workflow (yet).

@XVincentX

This comment has been minimized.

Contributor

XVincentX commented May 20, 2015

The repo is https://github.com/isteven/angular-omni-bar.
I got the problem, I did not know about the directory structure had to match the repo. Fixing.

"css": "0.1.10"
},
"shim": {
"isteven-angular-omni-bar": {

This comment has been minimized.

@guybedford

guybedford May 20, 2015

Member

This should just be isteven-moni-bar to refer to the main entry point.

@@ -0,0 +1,14 @@
{
"name": "isteven-angular-omni-bar",

This comment has been minimized.

@guybedford

guybedford May 20, 2015

Member

This is not necessary.

"name": "isteven-angular-omni-bar",
"main": "isteven-omni-bar.js",
"dependencies": {
"css": "0.1.10"

This comment has been minimized.

@guybedford

guybedford May 20, 2015

Member

It's best to use ^0.1.10 here to get new updates.

@guybedford

This comment has been minimized.

Member

guybedford commented May 20, 2015

Ah right, sorry didn't see that. I've included some further feedback above.

@XVincentX

This comment has been minimized.

Contributor

XVincentX commented May 20, 2015

@guybedford I addressed all your comments and the build is also passing. How about squashing the commits into a single one?

@guybedford

This comment has been minimized.

Member

guybedford commented May 20, 2015

Sure that would be great, thanks.

XVincentX
@XVincentX

This comment has been minimized.

Contributor

XVincentX commented May 22, 2015

@guybedford Done.

guybedford added a commit that referenced this pull request May 22, 2015

Merge pull request #388 from XVincentX/master
Added package override for isteven omni bar

@guybedford guybedford merged commit 3db2dde into jspm:master May 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment