refactor: Updated icon import to use tb-icons alias #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In my opinon we should use "@preact-icons/tb": "jsr:@preact-icons/tb@^1.0.13"because it's what deno generate when you do |
Contributor
Author
|
The import in deno.json was changed from "@preact-icons/tb": "jsr:@preact-icons/tb@^1.0.12", to "tb-icons": "jsr:@preact-icons/tb@^1.0.12", as requested in issue #967, which is mentioned in the main comment. This update helps clean up imports by eliminating the need to append Deno allows you to use import aliases instead of relying solely on the default name generated by |
Contributor
|
As said it's my opinion. Let's wait to see what's the opinion of maintainers |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Contributor
Author
|
@crowlKats fixed merge conflicts 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import cleaned up as requested in #967