Fix more todos

jsr107 · Nov 20, 2013 · 51a5f1e · 51a5f1e
1 parent a817c16
commit 51a5f1e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/...on/src/main/java/org/jsr107/ri/annotations/AbstractInternalCacheKeyInvocationContext.java b/...on/src/main/java/org/jsr107/ri/annotations/AbstractInternalCacheKeyInvocationContext.java
@@ -94,7 +94,6 @@ public StaticCacheKeyInvocationContext<A> getStaticCacheKeyInvocationContext() {
    */
   @Override
   protected Object[] getParameters(I invocation) {
-    // TODO Auto-generated method stub
     return null;
   }
 
@@ -104,7 +103,6 @@ protected Object[] getParameters(I invocation) {
    */
   @Override
   protected Method getMethod(I invocation) {
-    // TODO Auto-generated method stub
     return null;
   }
 
@@ -114,7 +112,6 @@ protected Method getMethod(I invocation) {
    */
   @Override
   protected Object getTarget(I invocation) {
-    // TODO Auto-generated method stub
     return null;
   }
 

diff --git a/cache-ri-impl/src/main/java/org/jsr107/ri/management/RICacheMXBean.java b/cache-ri-impl/src/main/java/org/jsr107/ri/management/RICacheMXBean.java
@@ -24,16 +24,17 @@
 /**
  * Class to help implementers
  *
- * todo add key and value types
- *
  * @param <K> the type of keys maintained by this map
  * @param <V> the type of mapped values*
  * @author Yannis Cosmadopoulos
  * @since 1.0
  */
 public class RICacheMXBean<K, V> implements CacheMXBean {
+
   private final Cache<K, V> cache;
 
+
+
   /**
    * Constructor
    *
@@ -43,6 +44,16 @@ public RICacheMXBean(Cache<K, V> cache) {
     this.cache = cache;
   }
 
+  @Override
+  public String getKeyType() {
+    return cache.getConfiguration(CompleteConfiguration.class).getKeyType().getName();
+  }
+
+  @Override
+  public String getValueType() {
+    return cache.getConfiguration(CompleteConfiguration.class).getValueType().getName();
+  }
+
   /**
    * {@inheritDoc}
    */