Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #188. Made one change as recommended by findbugs and excluded t…

…hree false positives.
  • Loading branch information...
commit 6457eb04834eb79ec97e4c2fec39afa30e4e0169 1 parent cfc8a32
@gregrluck gregrluck authored
View
11 findbugs/findbugs-exclude.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter>
+ <Match>
+ <!--Two false NO_NOTIFY_NOT_NOTIFYALL errors in CompletionListenerFuture-->
+ <Class name="javax.cache.integration.CompletionListenerFuture" />
+ </Match>
+ <Match>
+ <!--Non problematic SIC_INNER_SHOULD_BE_STATIC_ANON error in anonymous inner class in CachingProviderRegistry -->
+ <Class name="javax.cache.Caching$CachingProviderRegistry$1" />
+ </Match>
+</FindBugsFilter>
View
16 pom.xml
@@ -174,7 +174,6 @@
</plugin>
-
</plugins>
</build>
@@ -253,9 +252,9 @@
<reportSets>
<reportSet>
- <reports><!-- select reports -->
- <report>index</report>
- </reports>
+ <reports><!-- select reports -->
+ <!--<report>index</report>-->
+ </reports>
</reportSet>
</reportSets>
</plugin>
@@ -266,12 +265,9 @@
<artifactId>findbugs-maven-plugin</artifactId>
<version>2.5.2</version>
<configuration>
- <findbugsXmlWithMessages>true</findbugsXmlWithMessages>
- <outputDirectory>${project.build.directory}/findbugs</outputDirectory>
- <xmlOutput>true</xmlOutput>
- <!-- Optional directory to put findbugs xdoc xml report -->
- <xmlOutputDirectory>target/findbugs</xmlOutputDirectory>
- <failOnError>true</failOnError>
+ <effort>Max</effort>
+ <threshold>Low</threshold>
+ <excludeFilterFile>${basedir}/findbugs/findbugs-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
View
2  src/main/java/javax/cache/integration/CompletionListenerFuture.java
@@ -126,7 +126,7 @@ public boolean isDone() {
@Override
public Void get() throws InterruptedException, ExecutionException {
synchronized (this) {
- if (!isCompleted) {
+ while (!isCompleted) {
wait();
}

0 comments on commit 6457eb0

Please sign in to comment.
Something went wrong with that request. Please try again.