OSGi ready manifest #33

Closed
toelen opened this Issue Nov 8, 2011 · 5 comments

Projects

None yet

2 participants

@toelen
toelen commented Nov 8, 2011

Having an OSGi ready manifest for at least the api would be great, since the api changes repeatedly

@gregrluck
Member

Leen

I have made the changes to the pom.xml. It keeps the packaging type as jar but adds the OSGi content into the manifest using Felix.

See below.

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: gluck
Build-Jdk: 1.6.0_27
Export-Package: javax.cache;uses:="javax.transaction,javax.management"
;version="0.4.0.SNAPSHOT"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320800086599
Bundle-ManifestVersion: 2
Bundle-Activator: cache-api.impl.Activator
Bundle-Description: Sonatype helps open source projects to set up Mave
n repositories on https://oss.sonatype.org/
Import-Package: cache-api.impl,javax.enterprise.util;resolution:=optio
nal,javax.management,javax.transaction
Bundle-SymbolicName: cache-api

Questions:

  1. I don't exclude anything. I think that is right because the whole API is public.
  2. I have not defined an export service. Should I?
  3. cache-api.impl.Activator does not exist. I don't think we need an activator. Can I just remove this?

On 09/11/2011, at 2:00 AM, Leen Toelen wrote:

Having an OSGi ready manifest for at least the api would be great, since the api changes repeatedly


Reply to this email directly or view it on GitHub:
#33

Regards

Greg Luck

web: http://gregluck.com
skype: gregrluck
yahoo: gregrluck
mobile: +61 408 061 622

@toelen
toelen commented Nov 9, 2011

Hi Greg,

I ususally separate the manifest definition from the pom (so I can use the bndtools editor for it in eclipse). This is my bnd.bnd file

Export-Package: javax.cache;version=1.0,
javax.cache.annotation;version=1.0,
javax.cache.event;version=1.0,
javax.cache.spi;version=1.0,
javax.cache.transaction;version=1.0
Bundle-SymbolicName: javax.cache

The maven-bundle-plugin configuration simply becomes

<_include>bnd.bnd

And this generates the following manifest

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: leen toelen
Build-Jdk: 1.7.0
Export-Package: javax.cache;uses:="javax.cache.event,javax.cache.trans
action,javax.transaction,javax.management,javax.cache.spi";version="1
.0",javax.cache.annotation;uses:="javax.enterprise.util,javax.cache";
version="1.0",javax.cache.event;uses:="javax.cache";version="1.0",jav
ax.cache.spi;uses:="javax.cache";version="1.0",javax.cache.transactio
n;uses:="javax.cache";version="1.0"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320826650008
Bundle-ManifestVersion: 2
Bundle-Description: Sonatype helps open source projects to set up Mave
n repositories on https://oss.sonatype.org/
Import-Package: javax.enterprise.util;resolution:=optional,javax.manag
ement,javax.transaction
Bundle-SymbolicName: javax.cache

Of course the exported "1.0" version needs to change to the actual jsr version.

An activator is not needed not is the export service (these may be used by the actual implementations)

Regards,
Leen

@gregrluck
Member

Leen

I assume we do not want to hardcode this to version 1.

On 09/11/2011, at 6:19 PM, Leen Toelen wrote:

Hi Greg,

I ususally separate the manifest definition from the pom (so I can use the bndtools editor for it in eclipse). This is my bnd.bnd file

Export-Package: javax.cache;version=1.0,
javax.cache.annotation;version=1.0,
javax.cache.event;version=1.0,
javax.cache.spi;version=1.0,
javax.cache.transaction;version=1.0
Bundle-SymbolicName: javax.cache

The maven-bundle-plugin configuration simply becomes

<_include>bnd.bnd

And this generates the following manifest

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: leen toelen
Build-Jdk: 1.7.0
Export-Package: javax.cache;uses:="javax.cache.event,javax.cache.trans
action,javax.transaction,javax.management,javax.cache.spi";version="1
.0",javax.cache.annotation;uses:="javax.enterprise.util,javax.cache";
version="1.0",javax.cache.event;uses:="javax.cache";version="1.0",jav
ax.cache.spi;uses:="javax.cache";version="1.0",javax.cache.transactio
n;uses:="javax.cache";version="1.0"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320826650008
Bundle-ManifestVersion: 2
Bundle-Description: Sonatype helps open source projects to set up Mave
n repositories on https://oss.sonatype.org/
Import-Package: javax.enterprise.util;resolution:=optional,javax.manag
ement,javax.transaction
Bundle-SymbolicName: javax.cache

Of course the exported "1.0" version needs to change to the actual jsr version.

An activator is not needed not is the export service (these may be used by the actual implementations)

Regards,
Leen


Reply to this email directly or view it on GitHub:
#33 (comment)

Regards

Greg Luck

web: http://gregluck.com
skype: gregrluck
yahoo: gregrluck
mobile: +61 408 061 622

@gregrluck
Member

Leen

I found by removing the version in bnd.bnd that Felix puts in the correct version numbers:

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: gluck
Build-Jdk: 1.6.0_27
Export-Package: javax.cache;uses:="javax.cache.event,javax.cache.trans
action,javax.transaction,javax.management,javax.cache.spi";version="0
.4.0.SNAPSHOT",javax.cache.annotation;uses:="javax.enterprise.util,ja
vax.cache";version="0.4.0.SNAPSHOT",javax.cache.event;uses:="javax.ca
che";version="0.4.0.SNAPSHOT",javax.cache.spi;uses:="javax.cache";ver
sion="0.4.0.SNAPSHOT",javax.cache.transaction;uses:="javax.cache";ver
sion="0.4.0.SNAPSHOT"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320887704951
Bundle-ManifestVersion: 2
Bundle-Description: Sonatype helps open source projects to set up Mave
n repositories on https://oss.sonatype.org/
Import-Package: javax.enterprise.util;resolution:=optional,javax.manag
ement,javax.transaction
Bundle-SymbolicName: javax.cache

Have committed. Take a look.

On 09/11/2011, at 6:19 PM, Leen Toelen wrote:

Hi Greg,

I ususally separate the manifest definition from the pom (so I can use the bndtools editor for it in eclipse). This is my bnd.bnd file

Export-Package: javax.cache;version=1.0,
javax.cache.annotation;version=1.0,
javax.cache.event;version=1.0,
javax.cache.spi;version=1.0,
javax.cache.transaction;version=1.0
Bundle-SymbolicName: javax.cache

The maven-bundle-plugin configuration simply becomes

<_include>bnd.bnd

And this generates the following manifest

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: leen toelen
Build-Jdk: 1.7.0
Export-Package: javax.cache;uses:="javax.cache.event,javax.cache.trans
action,javax.transaction,javax.management,javax.cache.spi";version="1
.0",javax.cache.annotation;uses:="javax.enterprise.util,javax.cache";
version="1.0",javax.cache.event;uses:="javax.cache";version="1.0",jav
ax.cache.spi;uses:="javax.cache";version="1.0",javax.cache.transactio
n;uses:="javax.cache";version="1.0"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320826650008
Bundle-ManifestVersion: 2
Bundle-Description: Sonatype helps open source projects to set up Mave
n repositories on https://oss.sonatype.org/
Import-Package: javax.enterprise.util;resolution:=optional,javax.manag
ement,javax.transaction
Bundle-SymbolicName: javax.cache

Of course the exported "1.0" version needs to change to the actual jsr version.

An activator is not needed not is the export service (these may be used by the actual implementations)

Regards,
Leen


Reply to this email directly or view it on GitHub:
#33 (comment)

Regards

Greg Luck

web: http://gregluck.com
skype: gregrluck
yahoo: gregrluck
mobile: +61 408 061 622

@gregrluck gregrluck closed this Nov 10, 2011
@toelen
toelen commented Nov 10, 2011

Hi Greg,

this looks great, thanks a lot.

Regards,
Leen

On Thu, Nov 10, 2011 at 2:17 AM, Greg Luck
reply@reply.github.com
wrote:

Leen

I found by removing the version in bnd.bnd that Felix puts in the correct version numbers:

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: gluck
Build-Jdk: 1.6.0_27
Export-Package: javax.cache;uses:="javax.cache.event,javax.cache.trans
 action,javax.transaction,javax.management,javax.cache.spi";version="0
 .4.0.SNAPSHOT",javax.cache.annotation;uses:="javax.enterprise.util,ja
 vax.cache";version="0.4.0.SNAPSHOT",javax.cache.event;uses:="javax.ca
 che";version="0.4.0.SNAPSHOT",javax.cache.spi;uses:="javax.cache";ver
 sion="0.4.0.SNAPSHOT",javax.cache.transaction;uses:="javax.cache";ver
 sion="0.4.0.SNAPSHOT"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320887704951
Bundle-ManifestVersion: 2
Bundle-Description: Sonatype helps open source projects to set up Mave
 n repositories on https://oss.sonatype.org/
Import-Package: javax.enterprise.util;resolution:=optional,javax.manag
 ement,javax.transaction
Bundle-SymbolicName: javax.cache

Have committed. Take a look.

On 09/11/2011, at 6:19 PM, Leen Toelen wrote:

Hi Greg,

I ususally separate the manifest definition from the pom (so I can use the bndtools editor for it in eclipse). This is my bnd.bnd file

Export-Package: javax.cache;version=1.0,
      javax.cache.annotation;version=1.0,
      javax.cache.event;version=1.0,
      javax.cache.spi;version=1.0,
      javax.cache.transaction;version=1.0
Bundle-SymbolicName: javax.cache

The maven-bundle-plugin configuration simply becomes

      <_include>bnd.bnd

And this generates  the following manifest

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven Bundle Plugin
Built-By: leen toelen
Build-Jdk: 1.7.0
Export-Package: javax.cache;uses:="javax.cache.event,javax.cache.trans
action,javax.transaction,javax.management,javax.cache.spi";version="1
.0",javax.cache.annotation;uses:="javax.enterprise.util,javax.cache";
version="1.0",javax.cache.event;uses:="javax.cache";version="1.0",jav
ax.cache.spi;uses:="javax.cache";version="1.0",javax.cache.transactio
n;uses:="javax.cache";version="1.0"
Tool: Bnd-1.43.0
Bundle-Name: JSR107 API and SPI
Bundle-Version: 0.4.0.SNAPSHOT
Bnd-LastModified: 1320826650008
Bundle-ManifestVersion: 2
Bundle-Description: Sonatype helps open source projects to set up Mave
n repositories on https://oss.sonatype.org/
Import-Package: javax.enterprise.util;resolution:=optional,javax.manag
ement,javax.transaction
Bundle-SymbolicName: javax.cache

Of course the exported "1.0" version needs to change to the actual jsr version.

An activator is not needed not is the export service (these may be used by the actual implementations)

Regards,
Leen


Reply to this email directly or view it on GitHub:
#33 (comment)

Regards

Greg Luck

web: http://gregluck.com
skype: gregrluck
yahoo: gregrluck
mobile: +61 408 061 622


Reply to this email directly or view it on GitHub:
#33 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment