Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.jsr107.tck.management.CacheMBStatisticsBeanTest.testPutIfAbsent() #63

Closed
timeck opened this issue Nov 22, 2014 · 2 comments
Closed

org.jsr107.tck.management.CacheMBStatisticsBeanTest.testPutIfAbsent() #63

timeck opened this issue Nov 22, 2014 · 2 comments
Labels
Milestone

Comments

@timeck
Copy link
Member

@timeck timeck commented Nov 22, 2014

This test asserts that neither the "hit" or "miss" counts are affected by two Cache.putIfAbsent() operations

The spec lists this however (page 131):

operation Puts Removals Hits Misses
boolean putIfAbsent(K key, V value) Yes No Yes Yes

I am of the opinion that the first putIfAbsent() would count as both a "put" and a "miss", and the second call would record a "hit" in the cache statistics

timeck added a commit to timeck/jsr107tck that referenced this issue Nov 22, 2014
timeck added a commit to timeck/jsr107tck that referenced this issue Nov 22, 2014
@gregrluck gregrluck added this to the 1.1.0 milestone Dec 12, 2014
@gregrluck
Copy link
Member

@gregrluck gregrluck commented Dec 12, 2014

Yes you are correct. This change will break all of the existing implementations who have all followed the incorrect test and the incorrect RI.

We are therefore setting this 1.1.0 of the TCK which under the rules is not mandatory for 1.0 implementations. See the TCK Users Guide.

@gregrluck
Copy link
Member

@gregrluck gregrluck commented Jul 23, 2015

Moving this to 1.0.1. Implementations will have to fix their behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants