write_graphite plugin: Fix locking. #12

Merged
merged 1 commit into from Feb 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

octo commented Feb 4, 2012

wg_send_buffer() is called from wg_flush_nolock(). When calling wg_flush_nolock(), the thread has to hold cb->send_lock. Locking it again will fail, but this condition is not checked for. Then the lock is released twice which may result in concurrency issues.

@octo octo write_graphite plugin: Fix locking.
wg_send_buffer() is called from wg_flush_nolock(). When calling
wg_flush_nolock(), the thread has to hold cb->send_lock. Locking it again
will fail, but this condition is not checked for. Then the lock is
released twice which may result in concurrency issues.

Change-Id: Ie3062d50e6545adeb95b3a1938837c1f26835a56
5b8c299

@jssjr jssjr added a commit that referenced this pull request Feb 4, 2012

@jssjr jssjr Merge pull request #12 from octo/pu
write_graphite plugin: Fix locking.
f1acbc4

@jssjr jssjr merged commit f1acbc4 into jssjr:master Feb 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment