Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose/Reply] Add a shortcut to insert #snippet #1136

Closed
beatbesmer opened this issue Jan 9, 2020 · 3 comments
Closed

[Compose/Reply] Add a shortcut to insert #snippet #1136

beatbesmer opened this issue Jan 9, 2020 · 3 comments
Projects
Milestone

Comments

@beatbesmer
Copy link

@beatbesmer beatbesmer commented Jan 9, 2020

A shortcut might save some microseconts to type sequently the keys #sn ... :)

Similiar to CTRL-SHIFT-G for the signature

According bc474dc "This autocompletes the names of the most frequently used snippets that are usable by the current worker. "
Is this list limited or just sorted by the most frequently used?

@beatbesmer

This comment has been minimized.

Copy link
Author

@beatbesmer beatbesmer commented Jan 9, 2020

I also received some user-feedbacks:
Some worker are missing the live- filtering after pressing CTRL-SHIFT-I. So i propose them the usage of the #snippet command... in reply they ask if the additional keystrokes (compared to the previous version) could be saved

@jstanden jstanden added this to the 9.4.7 milestone Jan 9, 2020
@jstanden jstanden added this to New Features in 9.4.9 Jan 9, 2020
@jstanden

This comment has been minimized.

Copy link
Owner

@jstanden jstanden commented Jan 10, 2020

Implemented (potentially temporarily) as Ctrl+Shift+Period in 9.4.7. This inserts the #snippet text automatically and immediately offers suggestions.

@jstanden jstanden closed this Jan 10, 2020
9.4.9 automation moved this from New Features to Completed! Jan 10, 2020
@jstanden

This comment has been minimized.

Copy link
Owner

@jstanden jstanden commented Jan 10, 2020

@beatbesmer To your specific question, the suggestions from #snippet are sorted by most total uses at the moment. They should be by the worker's own uses, but worklist.records doesn't currently support sorting on that virtual column (it's an intermediary table and its usual approach doesn't work). We're currently refactoring this. It was related to the issue where sorting on 'My Uses' was unintentionally disabled entirely.

jstanden added a commit that referenced this issue Jan 10, 2020
…hift+Period` keyboard shortcut automatically inserts the `#snippet ` text and offers autocomplete suggestions. This particular keyboard combination may change in the near future as we consolidate keyboard shortcuts.

Fixes #1136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
9.4.9
  
Completed!
2 participants
You can’t perform that action at this time.