New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Records/Tickets] Support emoji characters in ticket subjects #855

Closed
jstanden opened this Issue Jan 9, 2019 · 3 comments

Comments

Projects
2 participants
@jstanden
Copy link
Owner

jstanden commented Jan 9, 2019

We need to convert this field to utf8mb4 and increase the varchar length accordingly.

@iammattmartin

This comment has been minimized.

Copy link

iammattmartin commented Jan 10, 2019

Would this cause mails being incorrectly imported? We had one the other day and thought it was just the message itself.

@jstanden

This comment has been minimized.

Copy link
Owner Author

jstanden commented Jan 10, 2019

It shouldn't affect anything other than the ticket subject becoming "(no subject)". It's not an issue within the message content because we store those in binary (without a specific encoding).

@jstanden jstanden added this to To do in 9.2 Jan 11, 2019

jstanden added a commit that referenced this issue Jan 11, 2019

* [Mail/Parser] Mitigated an issue in the email parser where subjects…
… containing 4-byte emoji characters became '(no subject)'. As a stopgap, these characters are now stripped and the rest of the subject is properly preserved. In the near future, the schema will be updated to support emoji in ticket subjects.

#855

@jstanden jstanden added this to the 9.2 milestone Feb 13, 2019

@jstanden

This comment has been minimized.

Copy link
Owner Author

jstanden commented Feb 13, 2019

Implemented in 9.2.

@jstanden jstanden closed this Feb 13, 2019

9.2 automation moved this from To do to Completed Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment