Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer variable leaks into global scope #4

Closed
Srokap opened this issue Mar 18, 2015 · 2 comments
Closed

Buffer variable leaks into global scope #4

Srokap opened this issue Mar 18, 2015 · 2 comments

Comments

@Srokap
Copy link

Srokap commented Mar 18, 2015

should use var buffer = instead of buffer =. Also adding "use strict"; is perhaps worth considering.

I generally caught the issue using mocha in my project for integration testing. Could consider adding here jshint perhaps if you're still interested in this library.

@jstapels
Copy link
Owner

Thanks, I haven't looked at this in awhile but when I get some time I'll add in the strict flag and try to clean it up a bit. Feel free to make a pull request if you've already fixed some issues.

@Srokap
Copy link
Author

Srokap commented Jan 6, 2016

It does not seem to be a problem on main branch anymore.

@Srokap Srokap closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants