Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for libassuan file sockets (WinGnuPG support) #6

Open
wants to merge 10 commits into
base: master
from

Conversation

@Lexicality
Copy link

commented Apr 19, 2019

This PR fixes #2 to resolve #1.

I left @NZSmartie's commits untouched, but I can rebase and squash if you like.

NZSmartie and others added some commits Dec 28, 2017

Use sys/windows constants for various errors
golint was complaining about these existing, and we already use
windows.ERROR_BROKEN_PIPE so it made sense to pull the others in too.
Address review comments
- Move os.NewSyscallError
- Remove unused variable
- Refactor code into dialAssuan and revert changes to dialPipe
Refactor code a little
- Have a constant for the polling timeout
- Use more standard error handling
- Don't open the pipe over and over if polling
- Don't call strconv.Atoi if we know there's no valid text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.