Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateFromMailMessage generates duplicated From and To addresses #115

Closed
jacargentina opened this issue Mar 19, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@jacargentina
Copy link

commented Mar 19, 2015

When using MimeKit.MimeMessage.CreateFromMailMessage static method to convert my .NET -MailMessage to a MimeMessage, i get a mail which has duplicates on the message.From and message.To collections.

Example

Original MailMessage

Result MimeMessage

@jstedfast

This comment has been minimized.

Copy link
Owner

commented Mar 19, 2015

I have a theory. Are you doing the conversion of your MailMessage into a MimeMessage after sending it via System.Net.Mail.SmtpClient?

Looking at Microsoft's reference source for MailMessage, it looks like the MailMessage.From, To, etc are not pushed to the MailMessage.Headers until the message is sent, but I'm not 100% sure about that (I've really just given their source code a quick glance).

Since CreateFromMailMessage() clones the headers and then adds the MailMessage.From, To, Cc, etc properties to the equivalent properties on MimeMessage, it would seem that the duplicating is coming from that.

@jacargentina

This comment has been minimized.

Copy link
Author

commented Mar 19, 2015

Exactly, i've sent it already!
Anyway, doen't it seems like a bug? Or at least, API documentation should warn about that assumption on "the message was not sent!"

@jstedfast jstedfast added the bug label Mar 19, 2015

@jstedfast

This comment has been minimized.

Copy link
Owner

commented Mar 19, 2015

Oh, yes, it is still a bug. I just wanted to figure out why my tests hadn't discovered the problem and to make sure I was understanding what the issue was.

I have a patch I'm about to commit...

jstedfast added a commit that referenced this issue Mar 19, 2015

@jstedfast

This comment has been minimized.

Copy link
Owner

commented Mar 19, 2015

Okay, should be fixed now. I'll make a new MimeKit release this weekend and push new packages to NuGet when I do.

@jstedfast jstedfast closed this Mar 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.