Provide MimeEntity.Load with a contentType parameter

[abock]

When using MimeKit for parsing HTTP content, the Content-Type header will have been removed from the stream already as part of the HTTP header parsing, leaving only the request body data in the stream to consume (at least in all sane/popular frameworks).

This is problematic because MimeKit needs this particular header when parsing. While easy to work around (especially thanks to ChainedStream to avoid copying the entire request body into memory first), it is very non-obvious what the problem is when one might first decide to mix HTTP and MimeKit.

I suggest an API overload for MimeEntity.Load:

MimeEntity.Load (request.InputStream, contentType: request.ContentType)

As a workaround, I have done the following in my production code for now:

var contentType = String.Format ("Content-Type: {0}\r\n\r\n", request.ContentType);
var chainedStream = new ChainedStream ();
chainedStream.Add (new MemoryStream (Encoding.UTF8.GetBytes (contentType)));
chainedStream.Add (request.InputStream);

var multipart = MimeEntity.Load (chainedStream) as Multipart;
...

[jstedfast]

Are you using System.Net.WebResponse? I'm just thinking that having a MimeEntity.Load (WebResponse) might be a nicer API than passing in a contentType string and a stream if the assumption is that people will be using WebResponses.

Otherwise, if you are using a 3rd party http stack, then it probably makes sense that I should have an API that takes a stream and content-type parameter.

[jstedfast]

hmmm, just found that link you sent me with your example usage and it does not appear that you are using System.Net.WebRequest/Response, so I'll probably need to have a contentType parameter.

[jstedfast]

I dropped the WebResponse parameter and went with ContentType and Stream, which I think is closer to what you need. I hesitate to use string contentType because it's less obvious what is needed, although maybe it's not so bad.

[abock]

Yeah, System.Net.WebRequest/Response is the old HTTP stack. Best not to write new code/APIs around that. Load(ContentType, Stream) is great. Thanks!