Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Vue 3 and Vite #6

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Migrate to Vue 3 and Vite #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0855aa
Migrate to Vue 3 and Vite
jsteinshouer Apr 2, 2022
33a1414
Remove docker compose version
jsteinshouer Apr 16, 2022
888f7eb
Change title
jsteinshouer Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"terminal.integrated.shell.linux": "/bin/zsh"
},

"postCreateCommand": "cd app && sudo npm install",
//"postCreateCommand": "cd app && sudo npm install",
// "remoteUser": "node",

// Add the IDs of extensions you want installed when the container is created.
Expand All @@ -19,7 +19,7 @@
"ortus-solutions.vscode-coldbox",
"ortus-solutions.vscode-testbox",
"dbaeumer.vscode-eslint",
"octref.vetur",
"johnsoncodehk.volar",
"bradlc.vscode-tailwindcss"
]

Expand Down
5 changes: 2 additions & 3 deletions .devcontainer/docker-compose.devcontainer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
version: '3.5'

services:

app:
build:
build:
context: .
target: app-devcontainer
volumes:
Expand Down
10 changes: 3 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,19 @@ RUN apt-get update && \

RUN sudo -u node npm install -g npm@latest

# Install global packages
RUN sudo -u node npm install -g @vue/cli @vue/cli-service-global

FROM app-devcontainer as app-dev
WORKDIR /workspace/app
# ENV PATH /app/node_modules/.bin:$PATH
COPY app/package*.json ./
ENV PATH /workspace/app/node_modules/.bin:$PATH
COPY app/package.json ./
RUN sudo npm install
EXPOSE 3000
CMD ["npm", "run", "serve"]
CMD ["npm", "run", "dev"]



# production build stage
FROM node:14.18.0-alpine as app-prod
RUN npm install -g npm@latest
#RUN npm install -g @vue/cli @vue/cli-service-global
ENV PATH /app/node_modules/.bin:$PATH
WORKDIR /app
COPY ./app .
Expand Down
13 changes: 13 additions & 0 deletions app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Movie App</title>
</head>
<body>
<div id="app"></div>
<script type="module" src="/src/main.js"></script>
</body>
</html>
Loading