Fix cleaning of `files_to_load` array. #57

merged 1 commit into from Jul 23, 2012


None yet

3 participants

rustyio commented Jul 18, 2012

Once files_to_load was called with map!, the calls to compact and uniq no longer had any effect. This caused errors such as:

    .../.gem/gems/spin-0.4.6/bin/spin:237:in `initialize': can't convert nil into String (TypeError)
        from /Users/rusty/.gem/gems/spin-0.4.6/bin/spin:237:in `new'
        from /Users/rusty/.gem/gems/spin-0.4.6/bin/spin:237:in `block in push'
        from /Users/rusty/.gem/gems/spin-0.4.6/bin/spin:236:in `map!'
        from /Users/rusty/.gem/gems/spin-0.4.6/bin/spin:236:in `push'
        from /Users/rusty/.gem/gems/spin-0.4.6/bin/spin:302:in `<top (required)>'
        from /Users/rusty/.gem/bin/spin:19:in `load'
        from /Users/rusty/.gem/bin/spin:19:in `<main>'

Fixed by changing to compact! and uniq!.

@jstorimer jstorimer merged commit 88a1dc2 into jstorimer:master Jul 23, 2012

Unfortunately this pull request is not correct, see my comment in #51: #51 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment