New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add letrec arbitrary combinator #193

Merged
merged 5 commits into from Mar 4, 2017

Conversation

Projects
None yet
2 participants
@thejohnfreeman
Contributor

thejohnfreeman commented Jan 8, 2017

Closes #192

@thejohnfreeman

This comment has been minimized.

Show comment
Hide comment
@thejohnfreeman

thejohnfreeman Jan 8, 2017

Contributor

I have to say this is probably the best project I've ever seen when it comes to automated code quality management: tests with no failures, lint with no violations, and coverage near 100%, all automated. 👏

Contributor

thejohnfreeman commented Jan 8, 2017

I have to say this is probably the best project I've ever seen when it comes to automated code quality management: tests with no failures, lint with no violations, and coverage near 100%, all automated. 👏

Show outdated Hide outdated lib/arbitrary.js
}
});`
*/
function letrec(definition) {

This comment has been minimized.

@phadej

phadej Jan 8, 2017

Member

smart. I see. The lazyArbs trick is because we don't know the key set before calling definition.

@phadej

phadej Jan 8, 2017

Member

smart. I see. The lazyArbs trick is because we don't know the key set before calling definition.

Show outdated Hide outdated lib/arbitrary.js
}
/**
- `letrec(

This comment has been minimized.

@phadej

phadej Jan 8, 2017

Member

I'd prefer triple backtick js comments:

```js
var foo = 1 + 1:
```
@phadej

phadej Jan 8, 2017

Member

I'd prefer triple backtick js comments:

```js
var foo = 1 + 1:
```
@thejohnfreeman

This comment has been minimized.

Show comment
Hide comment
@thejohnfreeman

thejohnfreeman Jan 11, 2017

Contributor

Github tells me "Changes requested", and I pushed those changes. Is there anything left for me to do to move this forward? Do I need to click a button somewhere? I don't want to be pushy; just wondering if this PR is waiting on me.

Contributor

thejohnfreeman commented Jan 11, 2017

Github tells me "Changes requested", and I pushed those changes. Is there anything left for me to do to move this forward? Do I need to click a button somewhere? I don't want to be pushy; just wondering if this PR is waiting on me.

@phadej

This comment has been minimized.

Show comment
Hide comment
@phadej

phadej Jan 12, 2017

Member

I haven't time to review this. It's on my todo list. Sorry for delays.

Member

phadej commented Jan 12, 2017

I haven't time to review this. It's on my todo list. Sorry for delays.

@phadej phadej dismissed their stale review Jan 12, 2017

Needs rereview

/**
- ```js
letrec(

This comment has been minimized.

@phadej

phadej Jan 12, 2017

Member

is the formatting somehow off here, or is it just my eyes?

@phadej

phadej Jan 12, 2017

Member

is the formatting somehow off here, or is it just my eyes?

This comment has been minimized.

@thejohnfreeman

thejohnfreeman Feb 5, 2017

Contributor

This has been fixed in the latest version. I don't know how to get Git to show that in the PR conversation, but you can see it in the commit.

@thejohnfreeman

thejohnfreeman Feb 5, 2017

Contributor

This has been fixed in the latest version. I don't know how to get Git to show that in the PR conversation, but you can see it in the commit.

});
arb.shrink = shrink.noop;
arb.show = show.def;
arb = arbitraryBless(arb);

This comment has been minimized.

@phadej

phadej Jan 12, 2017

Member

the arbitraryBless could rebless the fields too. No need to do this, just a mental not for myself.

@phadej

phadej Jan 12, 2017

Member

the arbitraryBless could rebless the fields too. No need to do this, just a mental not for myself.

@phadej phadej merged commit bb6da57 into jsverify:master Mar 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thejohnfreeman

This comment has been minimized.

Show comment
Hide comment
@thejohnfreeman

thejohnfreeman Mar 4, 2017

Contributor

Thank you!

Contributor

thejohnfreeman commented Mar 4, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment