[New] anchor-ambiguous-text: ignore punctuation

[mattxwang]

I had a chance to test anchor-ambiguous-text in our internal repos @chanzuckerberg, and a coworker flagged a false negative:

<a>learn more.</a>

The above should be flagged (it's ambiguous anchor text!), but because the rule doesn't ignore punctuation, it doesn't hit the existing dictionary.

So, this is a bite-sized PR that:

• adds failing test cases
• adjusts getAccessibleChildText to strip out punctuation
• documents the new behavioural change

[ljharb]

This seems like one of those bug fixes that might also be a breaking change :-/ i'd hate to put it behind an option, but that might be the safest approach?

[codecov]

Codecov Report

Merging #886 (bbae2c4) into main (8b889bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files         101      101           
  Lines        1555     1555           
  Branches      511      511           
=======================================
  Hits         1544     1544           
  Misses         11       11           

Impacted Files	Coverage Δ
src/util/getAccessibleChildText.js	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mattxwang]

Thanks for the very quick review!

This seems like one of those bug fixes that might also be a breaking change

We haven't released this rule, so I'm thinking that there wouldn't be a breaking change? Or do you mean that we should add a toggle for user convenience?

edit: sorry for the confusion, commented in the wrong thread

[ljharb]

looks good