From 3371be2159a09f66048955c3a1a5f6d7867ef522 Mon Sep 17 00:00:00 2001 From: Yannick Croissant Date: Sat, 16 Jan 2016 20:09:01 +0000 Subject: [PATCH] Really ignore ref in jsx-handler-names (fixes #396) --- lib/rules/jsx-handler-names.js | 4 ++++ tests/lib/rules/jsx-handler-names.js | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js index 769a74f35c..2d2861ed7b 100644 --- a/lib/rules/jsx-handler-names.js +++ b/lib/rules/jsx-handler-names.js @@ -27,6 +27,10 @@ module.exports = function(context) { var propKey = typeof node.name === 'object' ? node.name.name : node.name; var propValue = context.getSource(node.value.expression).replace(/^this\./, ''); + if (propKey === 'ref') { + return; + } + var propIsEventHandler = PROP_EVENT_HANDLER_REGEX.test(propKey); var propFnIsNamedCorrectly = EVENT_HANDLER_REGEX.test(propValue); diff --git a/tests/lib/rules/jsx-handler-names.js b/tests/lib/rules/jsx-handler-names.js index 7a0eeeeaf6..5b1094d6ef 100644 --- a/tests/lib/rules/jsx-handler-names.js +++ b/tests/lib/rules/jsx-handler-names.js @@ -64,6 +64,11 @@ ruleTester.run('jsx-handler-names', rule, { '' ].join('\n'), parserOptions: parserOptions + }, { + code: [ + '' + ].join('\n'), + parserOptions: parserOptions }], invalid: [{