From 4de38ef1e7f6c913f4153dac3833902bb9eec1b0 Mon Sep 17 00:00:00 2001 From: Jannis Hell Date: Sun, 16 Jan 2022 17:59:29 +0100 Subject: [PATCH] address comments - remove auto-fixer and adapt tests --- lib/rules/no-invalid-html-attribute.js | 5 ----- tests/lib/rules/no-invalid-html-attribute.js | 7 +++---- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/rules/no-invalid-html-attribute.js b/lib/rules/no-invalid-html-attribute.js index 31253dcfc5..e82c4c4316 100644 --- a/lib/rules/no-invalid-html-attribute.js +++ b/lib/rules/no-invalid-html-attribute.js @@ -321,11 +321,6 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN secondValue, missingValue: [...siblings].join(', '), }, - fix(fixer) { - if (siblings.size === 1) { - return fixer.replaceTextRange(singleAttributeParts[0].range, `${pairing}\u0020${[...siblings][0]}`); - } - }, }); } } diff --git a/tests/lib/rules/no-invalid-html-attribute.js b/tests/lib/rules/no-invalid-html-attribute.js index 2000774dab..f0b94fdea6 100644 --- a/tests/lib/rules/no-invalid-html-attribute.js +++ b/tests/lib/rules/no-invalid-html-attribute.js @@ -387,7 +387,7 @@ ruleTester.run('no-invalid-html-attribute', rule, { ], }, { - code: '', // this string contains nbsp + code: '', output: '', errors: [ { @@ -562,7 +562,6 @@ ruleTester.run('no-invalid-html-attribute', rule, { }, { code: '', - output: '', errors: [ { messageId: 'notAlone', @@ -575,7 +574,7 @@ ruleTester.run('no-invalid-html-attribute', rule, { }, { code: '', - output: '', + output: '', errors: [ { messageId: 'neverValid', @@ -606,7 +605,7 @@ ruleTester.run('no-invalid-html-attribute', rule, { }, { code: '', - output: '', + output: '', errors: [ { messageId: 'neverValid',