Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] drop node < 4 support #1038

Merged
merged 4 commits into from Apr 23, 2017
Merged

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jan 21, 2017

I've added some commits recently which fix support down to node 0.10 - those must be published in the 6.x line prior to merging this.

Merging this will be a semver-major change - it drops < node 4 support, and drops support for eslint v2. In the process, we'll be able to use any syntax and API that node 4 supports, yay!

I also enabled rules requiring template literals instead of concatenation, and autofixed them, both because I think it's a superior approach, and because it illustrates some of the new syntax we'll get to use :-)

(I'll manually keep this rebased and updated as time goes by, so ideally it will always be ready to merge when v7 comes along)

Also, require template literals instead of concatenation, and auto fix.
@ljharb ljharb added this to the 7.0.0 milestone Jan 21, 2017
@ljharb ljharb requested a review from yannickcr Jan 21, 2017
@yannickcr
Copy link
Member

yannickcr commented Jan 23, 2017

Wow! Great! Thanks for all this work. I'll try to review this PR tomorrow.

Copy link
Member

@yannickcr yannickcr left a comment

LGTM

Copy link
Collaborator

@lencioni lencioni left a comment

Merging this will be a semver-major change

I think it is time for v7 anyway. It would be nice to knock off everything else in the milestone after merging this. Are there other changes we should add to the v7 release milestone?

@ljharb
Copy link
Member Author

ljharb commented Jan 29, 2017

master must absolutely be published with v6, to fix the incorrect breaking changes in it, before this is merged and v7 is ready.

@ljharb
Copy link
Member Author

ljharb commented Apr 23, 2017

@yannickcr please don't release v7 before merging all the v7-tagged PRs; I'll update this one shortly and merge it today.

@ljharb ljharb merged commit 444c096 into jsx-eslint:master Apr 23, 2017
3 checks passed
@yannickcr
Copy link
Member

yannickcr commented Apr 23, 2017

Ho, I was more in the idea the release the v7 to be React 15.5.0 compatible and to postpone theses breaking changes for the v8.

But I'm ok to do all of this in a single major release.

@ljharb ljharb deleted the drop_pre_node_4 branch Apr 23, 2017
@ljharb
Copy link
Member Author

ljharb commented Apr 23, 2017

@yannickcr ah, i guess that would work too; the v7.0.0 milestone wasn't edited to v8 so that didn't come across. I think if we're doing a breaking change we might as well get them all in tho - I would have expected react 15.5 compatibility to be non-breaking, and to go in v6.

@yannickcr
Copy link
Member

yannickcr commented Apr 23, 2017

the v7.0.0 milestone wasn't edited to v8 so that didn't come across

yeah, my bad 😐

I think if we're doing a breaking change we might as well get them all in tho

right, it will avoid people some pain to only have one migration to do

I would have expected react 15.5 compatibility to be non-breaking, and to go in v6

I think this is unavoidable with the changes to createClass and the warnings added to no-deprecated

@ljharb
Copy link
Member Author

ljharb commented Apr 23, 2017

Couldn't we pivot on the react version in settings tho?

@ljharb
Copy link
Member Author

ljharb commented Apr 23, 2017

I figured the deprecation would only apply to 15.5 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants