Deprecate jsx-space-before-closing rule #1070
Merged
+18
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes #967
As discussed in #693 (comment), the
react/jsx-space-before-closing
can now be deprecated in favour ofreact/jsx-tag-spacing
which offers a superset of its functionality.This PR marks the old rule as deprecated and triggers a warning where it is still being used, reusing some code from the also deprecated
react/require-extension
rule.Let me know if I've missed any steps in the deprecation process!