Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jsx-space-before-closing rule #1070

Merged

Conversation

afairb
Copy link
Contributor

@afairb afairb commented Feb 13, 2017

Closes #967

As discussed in #693 (comment), the react/jsx-space-before-closing can now be deprecated in favour of react/jsx-tag-spacing which offers a superset of its functionality.

This PR marks the old rule as deprecated and triggers a warning where it is still being used, reusing some code from the also deprecated react/require-extension rule.

Let me know if I've missed any steps in the deprecation process!

…rule which offers a superset of it. jsx-space-before-closing still works but will trigger a warning.
Copy link
Collaborator

@lencioni lencioni left a comment

Thanks for the contribution!

@lencioni lencioni added this to the 7.0.0 milestone Feb 15, 2017
@yannickcr yannickcr merged commit 6d1485f into jsx-eslint:master Apr 23, 2017
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants