Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test false positive component detection for destructured createElement #1098

Merged
merged 1 commit into from Dec 27, 2018

Conversation

arian
Copy link
Contributor

@arian arian commented Mar 2, 2017

See #1089 (comment)

Before that pull request an arrow function such as: () => foo(bar("x")) would be detected as a component if createElement was destructured (import {createElement} from 'react').

This adds a test for display-name that it's ok that a function like that does not need a display name, as it's not a component.

ljharb
ljharb approved these changes Dec 27, 2018
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit b33ae84 into jsx-eslint:master Dec 27, 2018
1 check passed
This was referenced Dec 28, 2018
This was referenced Jan 4, 2019
@ghost ghost mentioned this pull request Jan 12, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants