Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend "react/" to rule options documentation code #1149

Merged
merged 1 commit into from Apr 13, 2017

Conversation

Adzz
Copy link
Contributor

@Adzz Adzz commented Apr 12, 2017

Using "jsx-pascal-case": ... leads to

1:1  error  Definition for rule 'jsx-pascal-case' was not found  jsx-pascal-case

We need "react/jsx-pascal-case": ... as shown in the Readme

ljharb
ljharb approved these changes Apr 12, 2017
Copy link
Member

@ljharb ljharb left a comment

Are there any other rules docs that need the prefix?

@Adzz
Copy link
Contributor Author

Adzz commented Apr 12, 2017

Good question, I didn't check! I can have a look see for you if you like

@Adzz
Copy link
Contributor Author

Adzz commented Apr 12, 2017

There's a few, let me do this proper and add them here, or would you prefer a different PR?

@ljharb
Copy link
Member

ljharb commented Apr 12, 2017

@Adzz here would be great, thanks :-) please rebase them all down to a single commit.

ljharb
ljharb approved these changes Apr 12, 2017
Copy link
Collaborator

@lencioni lencioni left a comment

Thanks!

@lencioni lencioni changed the title Update jsx-pascal-case.md Prepend "react/" to rule options documentation code Apr 13, 2017
@lencioni lencioni merged commit 24ea6f3 into jsx-eslint:master Apr 13, 2017
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants