Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Move "semver" to devDependencies #2595

Merged
merged 1 commit into from Mar 17, 2020
Merged

[deps] Move "semver" to devDependencies #2595

merged 1 commit into from Mar 17, 2020

Conversation

rajivshah3
Copy link
Contributor

@rajivshah3 rajivshah3 commented Mar 16, 2020 •
edited

semver is listed in dependencies, but only seems to be used in this test and not in the plugin itself:

https://github.com/yannickcr/eslint-plugin-react/blob/e231f44c38d28878039edeb43e009b153614ca0a/tests/lib/rules/no-unescaped-entities.js#L12

This PR moves it to devDependencies so that downstream projects don't have to include an unnecessary dependency.

ljharb
ljharb approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was my bad in #2583.

@ljharb ljharb merged commit 4ddf277 into jsx-eslint:master Mar 17, 2020
@rajivshah3 rajivshah3 deleted the fix/semver-dep branch March 17, 2020 22:58
@crupest crupest mentioned this pull request May 13, 2020
Merged
@gone-skiing gone-skiing mentioned this pull request May 13, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rajivshah3 @ljharb