Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-comment-text-nodes for @typescript-eslint/parser #2601

merged 1 commit into from Mar 23, 2020

Fix no-comment-text-nodes for @typescript-eslint/parser #2601

merged 1 commit into from Mar 23, 2020


Copy link

@Axnyff Axnyff commented Mar 23, 2020

Fixes #2599.

 - `@typescript-eslint/parser` requires eslint 5+ (and node 6+)

Fixes #2599.
Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've incorporated your fix as well.

@ljharb ljharb merged commit 6aa7874 into jsx-eslint:master Mar 23, 2020
Copy link
Contributor Author

Axnyff commented Mar 23, 2020

Thanks for your time and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

no-comments-in-text-node seems to be broken with @typescript-eslint/parser
2 participants