Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect TypeScript types for destructured default prop values #2780

Merged
merged 1 commit into from Sep 7, 2020
Merged

Detect TypeScript types for destructured default prop values #2780

merged 1 commit into from Sep 7, 2020

Conversation

sunghyunjo
Copy link
Contributor

Fix : #2762

@sunghyunjo sunghyunjo changed the title #2762 Update: destructured default prop values #2762 Detect TypeScript types for destructured default prop values Sep 1, 2020
@sunghyunjo sunghyunjo changed the title #2762 Detect TypeScript types for destructured default prop values Detect TypeScript types for destructured default prop values Sep 1, 2020
ljharb
ljharb reviewed Sep 1, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests with props like { foo, bar = '' }?

docs/rules/prop-types.md Show resolved Hide resolved
ljharb
ljharb approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and congrats on your first contribution!

@ljharb ljharb merged commit 9a569f7 into jsx-eslint:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[react/prop-types] Doesn't detect TypeScript types for destructured default prop values
2 participants
@sunghyunjo @ljharb