Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] fix linter errors #3261

Merged
merged 1 commit into from Apr 1, 2022
Merged

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Apr 1, 2022

Before:
91 problems (0 errors, 91 warnings)

After:
53 problems (0 errors, 53 warnings)

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #3261 (9c76175) into master (5bc571d) will increase coverage by 0.02%.
The diff coverage is 92.85%.

Current head 9c76175 differs from pull request most recent head 04da3f0. Consider uploading reports for the commit 04da3f0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3261      +/-   ##
==========================================
+ Coverage   97.67%   97.70%   +0.02%     
==========================================
  Files         121      121              
  Lines        8575     8570       -5     
  Branches     3112     3112              
==========================================
- Hits         8376     8373       -3     
+ Misses        199      197       -2     
Impacted Files Coverage Δ
lib/util/ast.js 97.57% <83.33%> (+1.12%) ⬆️
lib/rules/jsx-max-depth.js 98.55% <100.00%> (-0.03%) ⬇️
lib/rules/jsx-pascal-case.js 100.00% <100.00%> (ø)
lib/rules/jsx-sort-props.js 98.48% <100.00%> (ø)
lib/rules/require-render-return.js 100.00% <100.00%> (ø)
lib/rules/sort-comp.js 100.00% <100.00%> (ø)
lib/util/makeNoMethodSetStateRule.js 97.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc571d...04da3f0. Read the comment docs.

.eslintrc Outdated Show resolved Hide resolved
ljharb
ljharb approved these changes Apr 1, 2022
Copy link
Member

@ljharb ljharb left a comment

Looks great, thanks

lib/util/ast.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the fixlinterrors branch 2 times, most recently from 9c76175 to 04da3f0 Compare Apr 1, 2022
@ljharb ljharb merged commit 04da3f0 into jsx-eslint:master Apr 1, 2022
220 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants