Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Use curly single quote in error message for jsx-no-useless-fragment #3266

Merged
merged 1 commit into from Apr 7, 2022

Conversation

develohpanda
Copy link
Contributor

@develohpanda develohpanda commented Apr 7, 2022

As per title :)

Currently live:
image

@develohpanda develohpanda changed the title [Fix] Incorrect apostrophe used in error message for jsx-no-useless-fragment [Fix] Incorrect apostrophe used in error message for jsx-no-useless-fragment Apr 7, 2022
lib/rules/jsx-no-useless-fragment.js Outdated Show resolved Hide resolved
@develohpanda develohpanda changed the title [Fix] Incorrect apostrophe used in error message for jsx-no-useless-fragment [Fix] Use curly single quote in error message for jsx-no-useless-fragment Apr 7, 2022
ljharb
ljharb approved these changes Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #3266 (628ae7e) into master (365849c) will not change coverage.
The diff coverage is n/a.

Current head 628ae7e differs from pull request most recent head 29e104a. Consider uploading reports for the commit 29e104a to get more accurate results

@@           Coverage Diff           @@
##           master    #3266   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         121      121           
  Lines        8583     8583           
  Branches     3120     3120           
=======================================
  Hits         8385     8385           
  Misses        198      198           
Impacted Files Coverage Δ
lib/rules/jsx-no-useless-fragment.js 98.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365849c...29e104a. Read the comment docs.

@ljharb ljharb force-pushed the patch-1 branch 2 times, most recently from 29e104a to 8992a2b Compare Apr 7, 2022
@ljharb ljharb merged commit 8992a2b into jsx-eslint:master Apr 7, 2022
220 checks passed
@develohpanda develohpanda deleted the patch-1 branch Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants