Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the number of examples. #3293

Merged
merged 1 commit into from May 24, 2022
Merged

Conversation

ioggstream
Copy link
Contributor

@ioggstream ioggstream commented May 20, 2022

This PR

  • clarifies these were three different examples.
  • I didn't understand these were three different examples :)

I didn't understand these were three different examples.
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #3293 (3a2711c) into master (527db86) will not change coverage.
The diff coverage is n/a.

Current head 3a2711c differs from pull request most recent head c42b624. Consider uploading reports for the commit c42b624 to get more accurate results

@@           Coverage Diff           @@
##           master    #3293   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         123      123           
  Lines        8737     8737           
  Branches     3166     3166           
=======================================
  Hits         8535     8535           
  Misses        202      202           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527db86...c42b624. Read the comment docs.

@ljharb
Copy link
Member

ljharb commented May 23, 2022

Typically it's better not to count the number, because then we have to update it every time we add or remove an example.

Perhaps instead, splitting it into separate code blocks?

@ioggstream
Copy link
Contributor Author

ioggstream commented May 23, 2022

splitting it into separate code blocks?

That's ok! Can do it in this PR?

Typically it's better not to count the number,
because then we have to update it every time we add or remove an example.

Yep. In some cases though, clarifying that is useful. E.g. see this excerpt from the latest HTTP spec.

@ljharb
Copy link
Member

ljharb commented May 23, 2022

Yes, let's split it in this PR instead of hardcoding a count.

ljharb
ljharb approved these changes May 23, 2022
Copy link
Member

@ljharb ljharb left a comment

Thanks!

@ljharb ljharb merged commit c42b624 into jsx-eslint:master May 24, 2022
243 checks passed
@ioggstream ioggstream deleted the patch-1 branch May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants