Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] sort props test cases #3452



Copy link

All tests cases currently pass.
Fixed typos in test cases. Concatenated all invalid tests.

Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #3452 (462750e) into master (5efd774) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 462750e differs from pull request most recent head 902d555. Consider uploading reports for the commit 902d555 to get more accurate results

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
+ Coverage   97.54%   97.55%   +0.01%     
  Files         128      129       +1     
  Lines        9118     9199      +81     
  Branches     3321     3340      +19     
+ Hits         8894     8974      +80     
- Misses        224      225       +1     
Impacted Files Coverage Δ
lib/rules/sort-prop-types.js 98.27% <100.00%> (+0.04%) ⬆️
lib/util/propTypesSort.js 98.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ROSSROSALES ROSSROSALES force-pushed the ross-fix-sort-props-test-cases branch from bb8c181 to eb26aff Compare October 7, 2022 06:05
lib/rules/sort-prop-types.js Outdated Show resolved Hide resolved
@ROSSROSALES ROSSROSALES changed the title Ross fix sort props test cases [Fix] sort props test cases Oct 7, 2022
@ROSSROSALES ROSSROSALES force-pushed the ross-fix-sort-props-test-cases branch 4 times, most recently from 1125796 to 66365c0 Compare October 18, 2022 01:47
@ljharb ljharb force-pushed the ross-fix-sort-props-test-cases branch 2 times, most recently from 704faf2 to 902d555 Compare October 18, 2022 22:48
@ljharb ljharb merged commit 902d555 into jsx-eslint:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants